Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guidance about profile pictures #1165

Merged
merged 2 commits into from
Nov 1, 2024
Merged

Conversation

illicitonion
Copy link
Member

What does this change?

We want our trainees to set up images on their accounts - make this explicit and add image selection guidance. (While still suggesting alternatives for people who can't include images of themselves).

Common Content?

  • common-content/en/module/induction/accounts/index.md

We want our trainees to set up images on their accounts - make this
explicit and add image selection guidance. (While still suggesting
alternatives for people who can't include images of themselves).
Copy link

netlify bot commented Nov 1, 2024

Deploy Preview for cyf-piscine ready!

Name Link
🔨 Latest commit 6469c6d
🔍 Latest deploy log https://app.netlify.com/sites/cyf-piscine/deploys/6724d6ff4eb0e800082f6467
😎 Deploy Preview https://deploy-preview-1165--cyf-piscine.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 85 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 1, 2024

Deploy Preview for cyf-sdc ready!

Name Link
🔨 Latest commit 6469c6d
🔍 Latest deploy log https://app.netlify.com/sites/cyf-sdc/deploys/6724d6ff2dfa39000842fd3d
😎 Deploy Preview https://deploy-preview-1165--cyf-sdc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 1, 2024

Deploy Preview for cyf-programming ready!

Name Link
🔨 Latest commit 6469c6d
🔍 Latest deploy log https://app.netlify.com/sites/cyf-programming/deploys/6724d6ffb01dfc000840740a
😎 Deploy Preview https://deploy-preview-1165--cyf-programming.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (🟢 up 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 1, 2024

Deploy Preview for cyf-common canceled.

Name Link
🔨 Latest commit 6469c6d
🔍 Latest deploy log https://app.netlify.com/sites/cyf-common/deploys/6724d6ff0f6d890008a258ef

Copy link

netlify bot commented Nov 1, 2024

Deploy Preview for cyf-launch ready!

Name Link
🔨 Latest commit 6469c6d
🔍 Latest deploy log https://app.netlify.com/sites/cyf-launch/deploys/6724d6ffc3f86b000803d218
😎 Deploy Preview https://deploy-preview-1165--cyf-launch.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 1, 2024

Deploy Preview for cyf-tracks ready!

Name Link
🔨 Latest commit 6469c6d
🔍 Latest deploy log https://app.netlify.com/sites/cyf-tracks/deploys/6724d6ffa5a1a70008825280
😎 Deploy Preview https://deploy-preview-1165--cyf-tracks.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 1, 2024

Deploy Preview for cyf-itd canceled.

Name Link
🔨 Latest commit 6469c6d
🔍 Latest deploy log https://app.netlify.com/sites/cyf-itd/deploys/6724d6ffed709400088b5bf2

Copy link

netlify bot commented Nov 1, 2024

Deploy Preview for cyf-curriculum canceled.

Name Link
🔨 Latest commit 6469c6d
🔍 Latest deploy log https://app.netlify.com/sites/cyf-curriculum/deploys/6724d6ff44eec7000841ad42

Copy link
Member

@SallyMcGrath SallyMcGrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did we lose the robohash?

@illicitonion
Copy link
Member Author

How did we lose the robohash?

We didn't lose it, I just moved it up to the top of the page rather than being an after-thought after people have already created accounts :)

@illicitonion illicitonion merged commit 54a6bb8 into main Nov 1, 2024
34 checks passed
@illicitonion illicitonion deleted the professional-accounts-images branch November 1, 2024 13:28
@SallyMcGrath
Copy link
Member

How did we lose the robohash?

We didn't lose it, I just moved it up to the top of the page rather than being an after-thought after people have already created accounts :)

I meant from our collective intelligence really. Robohash has been our profile picture friend for years! (Also a fun Piscine project imo)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants