Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error if a README couldn't be found #1167

Merged
merged 3 commits into from
Nov 1, 2024
Merged

Error if a README couldn't be found #1167

merged 3 commits into from
Nov 1, 2024

Conversation

illicitonion
Copy link
Member

GetRemote returns nil not an error in this case

Also, fail the build on unrecognised block types.

GetRemote returns nil not an error in this case
This should be very rare, but always points at a significant error we
need to fix.
Copy link

netlify bot commented Nov 1, 2024

Deploy Preview for cyf-programming ready!

Name Link
🔨 Latest commit b4da8eb
🔍 Latest deploy log https://app.netlify.com/sites/cyf-programming/deploys/6724e324ae7038000863332f
😎 Deploy Preview https://deploy-preview-1167--cyf-programming.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (🟢 up 14 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 1, 2024

Deploy Preview for cyf-curriculum canceled.

Name Link
🔨 Latest commit b4da8eb
🔍 Latest deploy log https://app.netlify.com/sites/cyf-curriculum/deploys/6724e3247e38b70008953612

Copy link

netlify bot commented Nov 1, 2024

Deploy Preview for cyf-sdc ready!

Name Link
🔨 Latest commit b4da8eb
🔍 Latest deploy log https://app.netlify.com/sites/cyf-sdc/deploys/6724e324f6aa7400085de620
😎 Deploy Preview https://deploy-preview-1167--cyf-sdc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 1, 2024

Deploy Preview for cyf-common canceled.

Name Link
🔨 Latest commit b4da8eb
🔍 Latest deploy log https://app.netlify.com/sites/cyf-common/deploys/6724e324384e5500082cb58c

Copy link

netlify bot commented Nov 1, 2024

Deploy Preview for cyf-launch ready!

Name Link
🔨 Latest commit b4da8eb
🔍 Latest deploy log https://app.netlify.com/sites/cyf-launch/deploys/6724e324f6aa7400085de624
😎 Deploy Preview https://deploy-preview-1167--cyf-launch.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 1, 2024

Deploy Preview for cyf-piscine ready!

Name Link
🔨 Latest commit b4da8eb
🔍 Latest deploy log https://app.netlify.com/sites/cyf-piscine/deploys/6724e32455e57d00082daa7a
😎 Deploy Preview https://deploy-preview-1167--cyf-piscine.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 85 (🔴 down 15 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 1, 2024

Deploy Preview for cyf-tracks ready!

Name Link
🔨 Latest commit b4da8eb
🔍 Latest deploy log https://app.netlify.com/sites/cyf-tracks/deploys/6724e32456962600081d53ca
😎 Deploy Preview https://deploy-preview-1167--cyf-tracks.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 1, 2024

Deploy Preview for cyf-itd canceled.

Name Link
🔨 Latest commit b4da8eb
🔍 Latest deploy log https://app.netlify.com/sites/cyf-itd/deploys/6724e324a5a1a70008243b8f

Copy link
Member

@SallyMcGrath SallyMcGrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SallyMcGrath SallyMcGrath merged commit fcb2676 into main Nov 1, 2024
34 checks passed
@SallyMcGrath SallyMcGrath deleted the error-more branch November 1, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants