Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce metadata about track-types #1170

Merged
merged 9 commits into from
Dec 4, 2024
Merged

Introduce metadata about track-types #1170

merged 9 commits into from
Dec 4, 2024

Conversation

illicitonion
Copy link
Member

@illicitonion illicitonion commented Nov 4, 2024

What does this change?

As per our last syllabus team meeting, we think these are the three families of tracks we have.

Explain a bit of context as to what each category is. This maybe makes more sense to do under the headings of each group of tracks? But then the text is going to be awfully skinny...

Also, self-study tracks may have specific prereqs - we should list them so people know what they may want to opt to study.

Common Theme?

  • Adds the ability to show prereqs on module cards
  • Needs some styling on the card display

Org Content?

Updates tracks metadata.

Copy link

netlify bot commented Nov 4, 2024

Deploy Preview for cyf-curriculum canceled.

Name Link
🔨 Latest commit 2444588
🔍 Latest deploy log https://app.netlify.com/sites/cyf-curriculum/deploys/675089989d4c370008b225f0

Copy link

netlify bot commented Nov 4, 2024

Deploy Preview for cyf-common canceled.

Name Link
🔨 Latest commit 2444588
🔍 Latest deploy log https://app.netlify.com/sites/cyf-common/deploys/6750899823188b0008dc3117

Copy link

netlify bot commented Nov 4, 2024

Deploy Preview for cyf-launch ready!

Name Link
🔨 Latest commit 2444588
🔍 Latest deploy log https://app.netlify.com/sites/cyf-launch/deploys/675089988d61ff000848bbc5
😎 Deploy Preview https://deploy-preview-1170--cyf-launch.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 4, 2024

Deploy Preview for cyf-sdc ready!

Name Link
🔨 Latest commit 2444588
🔍 Latest deploy log https://app.netlify.com/sites/cyf-sdc/deploys/675089983a8312000828ab2b
😎 Deploy Preview https://deploy-preview-1170--cyf-sdc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 4, 2024

Deploy Preview for cyf-programming ready!

Name Link
🔨 Latest commit 2444588
🔍 Latest deploy log https://app.netlify.com/sites/cyf-programming/deploys/6750899844154a00082b912b
😎 Deploy Preview https://deploy-preview-1170--cyf-programming.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 85 (🟢 up 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 4, 2024

Deploy Preview for cyf-tracks ready!

Name Link
🔨 Latest commit 2444588
🔍 Latest deploy log https://app.netlify.com/sites/cyf-tracks/deploys/6750899910284e00088b7a29
😎 Deploy Preview https://deploy-preview-1170--cyf-tracks.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 4, 2024

Deploy Preview for cyf-piscine ready!

Name Link
🔨 Latest commit 2444588
🔍 Latest deploy log https://app.netlify.com/sites/cyf-piscine/deploys/67508999430c7700082b6782
😎 Deploy Preview https://deploy-preview-1170--cyf-piscine.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (🟢 up 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@illicitonion illicitonion mentioned this pull request Nov 4, 2024
5 tasks
Copy link

netlify bot commented Nov 4, 2024

Deploy Preview for cyf-itd canceled.

Name Link
🔨 Latest commit 2444588
🔍 Latest deploy log https://app.netlify.com/sites/cyf-itd/deploys/67508999ad46de0008cfe9f9

@SallyMcGrath
Copy link
Member

Oh Daniel do you want to break my heart! Absolutely not! 😂 😭

I mean, I completely agree with the organisation and the descriptions, but we can't have this layout I will DIE. I think it might another case for Taxonomies?

And we can put some kind of info dump underneath if we need to.

@illicitonion
Copy link
Member Author

I've pulled out the "adding a taxonomy map" into #1187 and will pick up the "adding metadata to the terms" piece here when that is merged.

This needs styling, but puts the raw content in place.
@illicitonion illicitonion marked this pull request as ready for review December 2, 2024 14:10
@illicitonion illicitonion changed the title Rework tracks grouping/presentation Introduce metadata about track-types Dec 2, 2024
@SallyMcGrath
Copy link
Member

Humbly apologise for blocking this!

@SallyMcGrath
Copy link
Member

I've pulled out the "adding a taxonomy map" into #1187 and will pick up the "adding metadata to the terms" piece here when that is merged.

Hi

I've done the layout changes and updated this branch from main. The question to answer is what specific condition do we want to show the metadata - I think it's when there's a term page, but reasonable people may differ.

Copy link
Member

@SallyMcGrath SallyMcGrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments and notes!

common-theme/layouts/partials/map-common.html Show resolved Hide resolved
@SallyMcGrath SallyMcGrath merged commit 8de4a35 into main Dec 4, 2024
34 checks passed
@SallyMcGrath SallyMcGrath deleted the rework-tracks branch December 4, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants