New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix oversight to make acceptance critera and description match #1184

Merged

SallyMcGrath merged 1 commit into main from fix-AI-step-oversight

Nov 8, 2024

Contributor

Ara225 commented Nov 8, 2024

What does this change?

Acceptance critea

Common Content?

No

Common Theme?

No

Issue number: N/A

Org Content?

ITD | Step 1

Checklist

[x ] I have read the contributing guidelines
I have checked my spelling and grammar with an automated tool
I have previewed my changes to check the markdown renders as I intend
I have run my code to check it works
My changes follow our Style Guide

Who needs to know about this?

None in particular - I just don't want to self review


          Update index.md

96a4f62

Ara225 assigned SallyMcGrath

netlify bot commented Nov 8, 2024 •

edited

Loading

✅ Deploy Preview for cyf-common canceled.

Name	Link
🔨 Latest commit	`96a4f62`
🔍 Latest deploy log	https://app.netlify.com/sites/cyf-common/deploys/672daf75fcefff0008294bb5

netlify bot commented Nov 8, 2024 •

edited

Loading

✅ Deploy Preview for cyf-curriculum canceled.

Name	Link
🔨 Latest commit	`96a4f62`
🔍 Latest deploy log	https://app.netlify.com/sites/cyf-curriculum/deploys/672daf7553e51000084e2bb8

netlify bot commented Nov 8, 2024 •

edited

Loading

✅ Deploy Preview for cyf-sdc ready!

Name	Link
🔨 Latest commit	`96a4f62`
🔍 Latest deploy log	https://app.netlify.com/sites/cyf-sdc/deploys/672daf75632fcc00088b6e71
😎 Deploy Preview	https://deploy-preview-1184--cyf-sdc.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify bot commented Nov 8, 2024 •

edited

Loading

✅ Deploy Preview for cyf-programming ready!

Name	Link
🔨 Latest commit	`96a4f62`
🔍 Latest deploy log	https://app.netlify.com/sites/cyf-programming/deploys/672daf751ef84b00092afa17
😎 Deploy Preview	https://deploy-preview-1184--cyf-programming.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 98 (no change from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 90 (no change from production) PWA: - View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify bot commented Nov 8, 2024 •

edited

Loading

✅ Deploy Preview for cyf-launch ready!

Name	Link
🔨 Latest commit	`96a4f62`
🔍 Latest deploy log	https://app.netlify.com/sites/cyf-launch/deploys/672daf75854e1e0008bf8265
😎 Deploy Preview	https://deploy-preview-1184--cyf-launch.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify bot commented Nov 8, 2024 •

edited

Loading

✅ Deploy Preview for cyf-piscine ready!

Name	Link
🔨 Latest commit	`96a4f62`
🔍 Latest deploy log	https://app.netlify.com/sites/cyf-piscine/deploys/672daf75cb67a90008258357
😎 Deploy Preview	https://deploy-preview-1184--cyf-piscine.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 85 (🔴 down 11 from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 100 (no change from production) PWA: 60 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify bot commented Nov 8, 2024 •

edited

Loading

✅ Deploy Preview for cyf-itd ready!

Name	Link
🔨 Latest commit	`96a4f62`
🔍 Latest deploy log	https://app.netlify.com/sites/cyf-itd/deploys/672daf7522d4bf00089c151c
😎 Deploy Preview	https://deploy-preview-1184--cyf-itd.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 92 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 100 (no change from production) PWA: 60 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify bot commented Nov 8, 2024 •

edited

Loading

✅ Deploy Preview for cyf-tracks ready!

Name	Link
🔨 Latest commit	`96a4f62`
🔍 Latest deploy log	https://app.netlify.com/sites/cyf-tracks/deploys/672daf7508929900085fe72e
😎 Deploy Preview	https://deploy-preview-1184--cyf-tracks.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

SallyMcGrath approved these changes

View reviewed changes

Member

SallyMcGrath left a comment

lgtm

SallyMcGrath merged commit c7842a1 into main

34 checks passed

SallyMcGrath deleted the fix-AI-step-oversight branch

November 8, 2024 11:32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet