Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content: Data Flows : TV Show #1189

Merged
merged 5 commits into from
Dec 5, 2024
Merged

Content: Data Flows : TV Show #1189

merged 5 commits into from
Dec 5, 2024

Conversation

SallyMcGrath
Copy link
Member

@SallyMcGrath SallyMcGrath commented Nov 9, 2024

What does this change?

Just closing down my tabs - here's the TV show project re-added to the website and renamed according to the project naming convention.

Org Content?

Data Flows | 1-3 | Project

Checklist

Who needs to know about this?

this was missing btw
Copy link

netlify bot commented Nov 9, 2024

Deploy Preview for cyf-curriculum canceled.

Name Link
🔨 Latest commit 80d11dd
🔍 Latest deploy log https://app.netlify.com/sites/cyf-curriculum/deploys/6751a394e88848000857d36e

Copy link

netlify bot commented Nov 9, 2024

Deploy Preview for cyf-tracks ready!

Name Link
🔨 Latest commit 80d11dd
🔍 Latest deploy log https://app.netlify.com/sites/cyf-tracks/deploys/6751a394017e910008fa6f28
😎 Deploy Preview https://deploy-preview-1189--cyf-tracks.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 9, 2024

Deploy Preview for cyf-programming ready!

Name Link
🔨 Latest commit 80d11dd
🔍 Latest deploy log https://app.netlify.com/sites/cyf-programming/deploys/6751a394fa56d300085c229d
😎 Deploy Preview https://deploy-preview-1189--cyf-programming.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (🟢 up 14 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 9, 2024

Deploy Preview for cyf-sdc ready!

Name Link
🔨 Latest commit 80d11dd
🔍 Latest deploy log https://app.netlify.com/sites/cyf-sdc/deploys/6751a394fc2e93000851c357
😎 Deploy Preview https://deploy-preview-1189--cyf-sdc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 9, 2024

Deploy Preview for cyf-common canceled.

Name Link
🔨 Latest commit 80d11dd
🔍 Latest deploy log https://app.netlify.com/sites/cyf-common/deploys/6751a394017e910008fa6f26

Copy link

netlify bot commented Nov 9, 2024

Deploy Preview for cyf-itd canceled.

Name Link
🔨 Latest commit 80d11dd
🔍 Latest deploy log https://app.netlify.com/sites/cyf-itd/deploys/6751a394e88848000857d373

Copy link

netlify bot commented Nov 9, 2024

Deploy Preview for cyf-piscine ready!

Name Link
🔨 Latest commit 80d11dd
🔍 Latest deploy log https://app.netlify.com/sites/cyf-piscine/deploys/6751a3942da35000087df0c6
😎 Deploy Preview https://deploy-preview-1189--cyf-piscine.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 85 (🔴 down 14 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 9, 2024

Deploy Preview for cyf-launch ready!

Name Link
🔨 Latest commit 80d11dd
🔍 Latest deploy log https://app.netlify.com/sites/cyf-launch/deploys/6751a394d92fe200080f7a54
😎 Deploy Preview https://deploy-preview-1189--cyf-launch.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@illicitonion
Copy link
Member

I'm not sure about this... This feels like something we could maybe do by applying tags to existing backlog items (to extract the pieces), rather than duplicating?

Currently this PR duplicates what you're meant to do each sprint between the module tickets (e.g. CodeYourFuture/Module-Data-Flows#46) and the project tickets (e.g. CodeYourFuture/Project-TV-Show#9)

I feel like either we should reference the project tickets in the sprint backlog, or we should reference the module tickets, but not both.

Concretely, if we move Level 200 back to sprint 1, I only want to be modifying that in one place not two.

@SallyMcGrath
Copy link
Member Author

SallyMcGrath commented Nov 18, 2024

I'm not sure about this... This feels like something we could maybe do by applying tags to existing backlog items (to extract the pieces), rather than duplicating?

Currently this PR duplicates what you're meant to do each sprint between the module tickets (e.g. CodeYourFuture/Module-Data-Flows#46) and the project tickets (e.g. CodeYourFuture/Project-TV-Show#9)

I feel like either we should reference the project tickets in the sprint backlog, or we should reference the module tickets, but not both.

Concretely, if we move Level 200 back to sprint 1, I only want to be modifying that in one place not two.

It references the tickets using sprint filters, so if you update the label, it moves by itself. It's not duplicating - it mirrors the project. Can you say a bit more, because to me it sounds like your solution is this already?

Edited! OK now I see what you're saying. You're not talking about the content in this PR, you're talking about the tickets between the module and the project repo. These tickets are the original tickets - they already existed - so I didn't pick up what you meant.

It sounds like you're wondering whether we need the module tickets sending them to the project tickets. We have it that way because trainees felt it wasn't clear what to do when and asked for both sets. They liked the TV show project being a separate understandable thing - this came up in feedback a few times - but mentors worried they would miss the coursework if it wasn't spelled out on the main repo too.

I actually have a preference for fewer tickets myself, but I'd keep the project tickets and dump the module ones. This would be vastly easier for maintenance and for lower context volunteers. What do you think?

@illicitonion
Copy link
Member

I think we agreed to block this on #1204 but let me know if that's not how you felt we concluded!

@SallyMcGrath
Copy link
Member Author

I think we agreed to block this on #1204 but let me know if that's not how you felt we concluded!

Yep, we have blocked

@SallyMcGrath SallyMcGrath removed the blocked Blocked by something explained in comments label Dec 5, 2024
Copy link
Member

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woo! 🎉

@SallyMcGrath SallyMcGrath merged commit 5b6d4c0 into main Dec 5, 2024
34 checks passed
@SallyMcGrath SallyMcGrath deleted the content/TV-Show branch December 5, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants