Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEMP files for objective and task shortcodes #1190

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Conversation

SallyMcGrath
Copy link
Member

@SallyMcGrath SallyMcGrath commented Nov 9, 2024

What does this change?

this is temporary - we probably want to not just use codefencing and use commented out hugo shortcodes so the task lists still work on github. So here are the entry files for those shortcodes so they can start being used.

However we actually don't want this sort of horrible ball of code and it makes sense to rationalise all these various ways of getting objectives in order to make the success page cleaner.

But that's a task for a clearer head than I currently have, so here, a quick fix so annotation can proceed without breaking the build

Common Theme?

  • Yes

Issue number: #issue-number Partial towards #950

Checklist

Who needs to know about this?

this is temporary - we probably want to not just use codefencing and use commented out hugo shortcodes so the task lists still work on github. However we also don't want this sort of glob of code and it makes sense to rationalise  all these various ways of getting objectives in order to make the success page cleaner. But that's a task for a clearer head than I currently have, so here, a quick fix so annotation can proceed without breaking the build
Copy link

netlify bot commented Nov 9, 2024

Deploy Preview for cyf-launch ready!

Name Link
🔨 Latest commit 5fe5316
🔍 Latest deploy log https://app.netlify.com/sites/cyf-launch/deploys/672fa8b42ffc730008c0abcc
😎 Deploy Preview https://deploy-preview-1190--cyf-launch.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 9, 2024

Deploy Preview for cyf-tracks ready!

Name Link
🔨 Latest commit 5fe5316
🔍 Latest deploy log https://app.netlify.com/sites/cyf-tracks/deploys/672fa8b4eb302a0008b021f7
😎 Deploy Preview https://deploy-preview-1190--cyf-tracks.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 9, 2024

Deploy Preview for cyf-curriculum ready!

Name Link
🔨 Latest commit 5fe5316
🔍 Latest deploy log https://app.netlify.com/sites/cyf-curriculum/deploys/672fa8b4edbe580009fb7dd8
😎 Deploy Preview https://deploy-preview-1190--cyf-curriculum.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 93 (🔴 down 4 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 9, 2024

Deploy Preview for cyf-sdc ready!

Name Link
🔨 Latest commit 5fe5316
🔍 Latest deploy log https://app.netlify.com/sites/cyf-sdc/deploys/672fa8b45ea6a30008ac9242
😎 Deploy Preview https://deploy-preview-1190--cyf-sdc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 9, 2024

Deploy Preview for cyf-programming ready!

Name Link
🔨 Latest commit 5fe5316
🔍 Latest deploy log https://app.netlify.com/sites/cyf-programming/deploys/672fa8b4221731000894be3e
😎 Deploy Preview https://deploy-preview-1190--cyf-programming.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (🟢 up 14 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 9, 2024

Deploy Preview for cyf-common canceled.

Name Link
🔨 Latest commit 5fe5316
🔍 Latest deploy log https://app.netlify.com/sites/cyf-common/deploys/672fa8b437886500081614f9

Copy link

netlify bot commented Nov 9, 2024

Deploy Preview for cyf-piscine ready!

Name Link
🔨 Latest commit 5fe5316
🔍 Latest deploy log https://app.netlify.com/sites/cyf-piscine/deploys/672fa8b44818a30008fa1005
😎 Deploy Preview https://deploy-preview-1190--cyf-piscine.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (🟢 up 15 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 9, 2024

Deploy Preview for cyf-itd ready!

Name Link
🔨 Latest commit 5fe5316
🔍 Latest deploy log https://app.netlify.com/sites/cyf-itd/deploys/672fa8b48094f800088572cd
😎 Deploy Preview https://deploy-preview-1190--cyf-itd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 92 (🔴 down 8 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, temp!

common-theme/layouts/shortcodes/tasks.html Show resolved Hide resolved
@illicitonion illicitonion merged commit d71d30f into main Nov 12, 2024
34 checks passed
@illicitonion illicitonion deleted the objectives-and-tasks branch November 12, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants