Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete prereqs from Piscine #1194

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

illicitonion
Copy link
Member

What does this change?

See discussion from https://codeyourfuture.slack.com/archives/C012UUW69S8/p1729604686501789?thread_ts=1729514033.295269&cid=C012UUW69S8

We will re-add error handling when we've re-added this to ITP.

The Jest updates are reflecting what we actually teach in ITP - the other things aren't super necessary they're Just More APIs.

Switch isn't needed and can be picked up as needed through Google.

Common Content?

Yes, but this is maybe actually super CYF specific and maybe all the Piscine stuff should get moved into the Piscine module.

See discussion from https://codeyourfuture.slack.com/archives/C012UUW69S8/p1729604686501789?thread_ts=1729514033.295269&cid=C012UUW69S8

We will re-add error handling when we've re-added this to ITP.

The Jest updates are reflecting what we actually teach in ITP - the
other things aren't super necessary they're Just More APIs.

Switch isn't needed and can be picked up as needed through Google.
Copy link

netlify bot commented Nov 12, 2024

Deploy Preview for cyf-sdc ready!

Name Link
🔨 Latest commit 3cac7b1
🔍 Latest deploy log https://app.netlify.com/sites/cyf-sdc/deploys/67335146459b3e0008e7d72d
😎 Deploy Preview https://deploy-preview-1194--cyf-sdc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 12, 2024

Deploy Preview for cyf-itd canceled.

Name Link
🔨 Latest commit 3cac7b1
🔍 Latest deploy log https://app.netlify.com/sites/cyf-itd/deploys/67335146f3588500085883e2

Copy link

netlify bot commented Nov 12, 2024

Deploy Preview for cyf-common canceled.

Name Link
🔨 Latest commit 3cac7b1
🔍 Latest deploy log https://app.netlify.com/sites/cyf-common/deploys/673351468244430008e9dac2

Copy link

netlify bot commented Nov 12, 2024

Deploy Preview for cyf-programming ready!

Name Link
🔨 Latest commit 3cac7b1
🔍 Latest deploy log https://app.netlify.com/sites/cyf-programming/deploys/67335146c1d071000858fc24
😎 Deploy Preview https://deploy-preview-1194--cyf-programming.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 98 (🟢 up 13 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 12, 2024

Deploy Preview for cyf-curriculum canceled.

Name Link
🔨 Latest commit 3cac7b1
🔍 Latest deploy log https://app.netlify.com/sites/cyf-curriculum/deploys/67335146bd9cf000085320a1

Copy link

netlify bot commented Nov 12, 2024

Deploy Preview for cyf-piscine ready!

Name Link
🔨 Latest commit 3cac7b1
🔍 Latest deploy log https://app.netlify.com/sites/cyf-piscine/deploys/673351460c343d000878abf9
😎 Deploy Preview https://deploy-preview-1194--cyf-piscine.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (🟢 up 14 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 12, 2024

Deploy Preview for cyf-tracks ready!

Name Link
🔨 Latest commit 3cac7b1
🔍 Latest deploy log https://app.netlify.com/sites/cyf-tracks/deploys/67335146777fea00089dd2d4
😎 Deploy Preview https://deploy-preview-1194--cyf-tracks.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 12, 2024

Deploy Preview for cyf-launch ready!

Name Link
🔨 Latest commit 3cac7b1
🔍 Latest deploy log https://app.netlify.com/sites/cyf-launch/deploys/673351468244430008e9dac4
😎 Deploy Preview https://deploy-preview-1194--cyf-launch.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@SallyMcGrath SallyMcGrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the caveat we will def return try/catch/throw next iteration

@SallyMcGrath SallyMcGrath merged commit 21f484d into main Nov 28, 2024
34 checks passed
@SallyMcGrath SallyMcGrath deleted the remove-missing-piscine-prereqs branch November 28, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants