Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix that annoying time bug on day plan #1229

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Conversation

SallyMcGrath
Copy link
Member

@SallyMcGrath SallyMcGrath commented Dec 5, 2024

What does this change?

On the day plan, if you nest blocks as options, the time stamp accumulates them and the times go wrong.

I've excluded nested blocks from the timestamper.

Common Theme?

  • Yes see above

Checklist

Who needs to know about this?

Copy link

netlify bot commented Dec 5, 2024

Deploy Preview for cyf-itd canceled.

Name Link
🔨 Latest commit 5a2ce91
🔍 Latest deploy log https://app.netlify.com/sites/cyf-itd/deploys/675221b9f6e2970007aca290

Copy link

netlify bot commented Dec 5, 2024

Deploy Preview for cyf-common canceled.

Name Link
🔨 Latest commit 5a2ce91
🔍 Latest deploy log https://app.netlify.com/sites/cyf-common/deploys/675221b94a00d500081a5369

Copy link

netlify bot commented Dec 5, 2024

Deploy Preview for cyf-programming ready!

Name Link
🔨 Latest commit 5a2ce91
🔍 Latest deploy log https://app.netlify.com/sites/cyf-programming/deploys/675221b92a8a6300080cae78
😎 Deploy Preview https://deploy-preview-1229--cyf-programming.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 85 (🔴 down 14 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 5, 2024

Deploy Preview for cyf-curriculum canceled.

Name Link
🔨 Latest commit 5a2ce91
🔍 Latest deploy log https://app.netlify.com/sites/cyf-curriculum/deploys/675221b9271fa4000891d078

Copy link

netlify bot commented Dec 5, 2024

Deploy Preview for cyf-sdc ready!

Name Link
🔨 Latest commit 5a2ce91
🔍 Latest deploy log https://app.netlify.com/sites/cyf-sdc/deploys/675221b96c4b2c0008c6dc7a
😎 Deploy Preview https://deploy-preview-1229--cyf-sdc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 5, 2024

Deploy Preview for cyf-launch ready!

Name Link
🔨 Latest commit 5a2ce91
🔍 Latest deploy log https://app.netlify.com/sites/cyf-launch/deploys/675221b98f316200099743d0
😎 Deploy Preview https://deploy-preview-1229--cyf-launch.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 5, 2024

Deploy Preview for cyf-piscine ready!

Name Link
🔨 Latest commit 5a2ce91
🔍 Latest deploy log https://app.netlify.com/sites/cyf-piscine/deploys/675221b991552800081b3de9
😎 Deploy Preview https://deploy-preview-1229--cyf-piscine.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (🟢 up 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 5, 2024

Deploy Preview for cyf-tracks ready!

Name Link
🔨 Latest commit 5a2ce91
🔍 Latest deploy log https://app.netlify.com/sites/cyf-tracks/deploys/675221b90ff200000804e3c6
😎 Deploy Preview https://deploy-preview-1229--cyf-tracks.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@moneyinthesky
Copy link
Contributor

Nice 👌 Thanks!

@SallyMcGrath SallyMcGrath merged commit bad59a5 into main Dec 6, 2024
34 checks passed
@SallyMcGrath SallyMcGrath deleted the fix/nested-times branch December 6, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants