Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two tiny tweaks: legends in flow, animated details #1264

Merged
merged 4 commits into from
Dec 30, 2024
Merged

Conversation

SallyMcGrath
Copy link
Member

  1. This is how you put legends in flow so it stays where it is and pushes siblings down instead of growing up like the default behaviour. It is a bit esoteric if you don't Just Know From Life.

  2. While I am here, here's an animation on details that doesn't push content down in flow, so, the opposite.

Copy link

netlify bot commented Dec 23, 2024

Deploy Preview for cyf-common failed. Why did it fail? →

Name Link
🔨 Latest commit 0147403
🔍 Latest deploy log https://app.netlify.com/sites/cyf-common/deploys/6772994f31b77d000816944d

Copy link

netlify bot commented Dec 23, 2024

Deploy Preview for cyf-sdc ready!

Name Link
🔨 Latest commit 0147403
🔍 Latest deploy log https://app.netlify.com/sites/cyf-sdc/deploys/6772994fa4fdff0008e9d625
😎 Deploy Preview https://deploy-preview-1264--cyf-sdc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 23, 2024

Deploy Preview for cyf-curriculum canceled.

Name Link
🔨 Latest commit 0147403
🔍 Latest deploy log https://app.netlify.com/sites/cyf-curriculum/deploys/6772994ffd7a470008284a1c

Copy link

netlify bot commented Dec 23, 2024

Deploy Preview for cyf-tracks ready!

Name Link
🔨 Latest commit 0147403
🔍 Latest deploy log https://app.netlify.com/sites/cyf-tracks/deploys/6772994f31b77d0008169452
😎 Deploy Preview https://deploy-preview-1264--cyf-tracks.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 23, 2024

Deploy Preview for cyf-programming ready!

Name Link
🔨 Latest commit 0147403
🔍 Latest deploy log https://app.netlify.com/sites/cyf-programming/deploys/6772994f2d89f40008ddc618
😎 Deploy Preview https://deploy-preview-1264--cyf-programming.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 23, 2024

Deploy Preview for cyf-launch ready!

Name Link
🔨 Latest commit 0147403
🔍 Latest deploy log https://app.netlify.com/sites/cyf-launch/deploys/6772994f09e7bc0008744de3
😎 Deploy Preview https://deploy-preview-1264--cyf-launch.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 23, 2024

Deploy Preview for cyf-piscine ready!

Name Link
🔨 Latest commit 0147403
🔍 Latest deploy log https://app.netlify.com/sites/cyf-piscine/deploys/6772994f5854400008561522
😎 Deploy Preview https://deploy-preview-1264--cyf-piscine.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 98 (🟢 up 2 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 23, 2024

Deploy Preview for cyf-itd ready!

Name Link
🔨 Latest commit 0147403
🔍 Latest deploy log https://app.netlify.com/sites/cyf-itd/deploys/6772994feb8afb000818a106
😎 Deploy Preview https://deploy-preview-1264--cyf-itd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (🟢 up 3 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@SallyMcGrath SallyMcGrath added this to the SDC-1-2025 Launch milestone Dec 29, 2024
Copy link
Member

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@SallyMcGrath SallyMcGrath enabled auto-merge (squash) December 30, 2024 13:00
@SallyMcGrath SallyMcGrath merged commit ad24421 into main Dec 30, 2024
24 of 30 checks passed
@SallyMcGrath SallyMcGrath deleted the feature/legend branch December 30, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants