Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use $URL not $DEPLOY_PRIME_URL #1265

Merged
merged 2 commits into from
Dec 27, 2024
Merged

Use $URL not $DEPLOY_PRIME_URL #1265

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39ba212
Use $URL not $DEPLOY_PRIME_URL for prod deploys
illicitonion Dec 27, 2024
d6e4f72
Merge branch 'main' into use-url-not-deploy-prime-url
SallyMcGrath Dec 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion tooling/common-config/deploy-netlify.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,10 @@ set -euo pipefail

npm install --legacy-peer-deps

URL_TO_USE="${URL}"
if [[ "${PULL_REQUEST}" == "true" ]]; then
URL_TO_USE="${DEPLOY_PRIME_URL}"
fi

# We set --baseURL on netlify so that any references to .Permalink end up pointing at deploy preview pages, rather than being hard-coded to point at the production URLs.
hugo --minify --environment production --baseURL $DEPLOY_PRIME_URL && npx pagefind --site "public"
hugo --minify --environment production --baseURL "${URL_TO_USE}" && npx pagefind --site "public"
Loading