Ensure every site configures markup #1274
Open
+270
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cyf-curriculum canceled.
|
✅ Deploy Preview for cyf-common ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for cyf-sdc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for cyf-programming ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for cyf-launch ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for cyf-tracks ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This avoids needing to notice and play whack-a-mole when things aren't configured as we expect. Also, add a --fix mode which will try to fix things for you.
✅ Deploy Preview for cyf-itd ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
illicitonion
force-pushed
the
ensure-markup
branch
from
0ed8841 to
4073615
Compare
✅ Deploy Preview for cyf-piscine ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for cyf-piscine ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
SallyMcGrath
requested changes
Dec 30, 2024
There was a problem hiding this comment.
Thank you for this. I do want this - but before we require it, can we check what can be inherited?
I'm not sure we do need to copy pasta as much config as we currently do, so would like to not bake that in (except the necessary). Can you read over this and have a think?
https://gohugo.io/getting-started/configuration/#configure-page
| @@ -63,20 +63,24 @@ maxAge="6h" | |||
| getenv = ["^HUGO_CURRICULUM_GITHUB_BEARER_TOKEN$"] | |||
|
|
|||
|
|
|||
| theme = "common-theme" | |||
There was a problem hiding this comment.
I actually don't think we need to declare common theme any more if we're importing the module btw
| @@ -24,17 +24,22 @@ baseURL = "https://sdc.codeyourfuture.io/" | |||
| [params] | |||
| googleFonts="https://fonts.googleapis.com/css2?family=Space+Grotesk:wght@300;500;700&family=Inter:wght@400;600&display=swap" | |||
|
|
|||
| #this makes the section nav go the right way | |||
| # because of this 'unexpected behaviour' https://gohugo.io/methods/page/nextinsection/ | |||
There was a problem hiding this comment.
Can this one not be inherited from theme?
Actually maybe this should be tidied up a bit more. What can we inherit from org-cyf-theme module?
https://gohugo.io/getting-started/configuration/#configure-page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids needing to notice and play whack-a-mole when things aren't
configured as we expect.
Also, add a --fix mode which will try to fix things for you.