Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content: slightly reduce criteria on ITP success steps #1275

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

SallyMcGrath
Copy link
Member

@SallyMcGrath SallyMcGrath commented Dec 30, 2024

What does this change?

I've slightly reduced the criteria for checks to make the step review quicker.
I've slightly reworded to make it clearer based on common mistakes I've seen.
I've added a tip to tell them to submit their step even if we are a bit behind with our reviews -- we never want to limit a trainee based on external circumstances if we don't have to
I've added a link to the place to submit their step

Org Content?

Data groups | Success
Data flows | Success

Checklist

Who needs to know about this?

@kfklein and @moneyinthesky please note these minor changes. Will you be able to update the step (I can do this if not)?

1. add link to dashboard
2. also tell them to submit even if they haven't go their review yet
@SallyMcGrath SallyMcGrath added the 👀 Review Requirements Changes requested to meet requirements label Dec 30, 2024
Copy link

netlify bot commented Dec 30, 2024

Deploy Preview for cyf-sdc ready!

Name Link
🔨 Latest commit ce1455f
🔍 Latest deploy log https://app.netlify.com/sites/cyf-sdc/deploys/677284c4167d210008fb4b08
😎 Deploy Preview https://deploy-preview-1275--cyf-sdc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 30, 2024

Deploy Preview for cyf-programming ready!

Name Link
🔨 Latest commit ce1455f
🔍 Latest deploy log https://app.netlify.com/sites/cyf-programming/deploys/677284c44a58160008972f9e
😎 Deploy Preview https://deploy-preview-1275--cyf-programming.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 30, 2024

Deploy Preview for cyf-launch ready!

Name Link
🔨 Latest commit ce1455f
🔍 Latest deploy log https://app.netlify.com/sites/cyf-launch/deploys/677284c424b04800089a2a19
😎 Deploy Preview https://deploy-preview-1275--cyf-launch.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 30, 2024

Deploy Preview for cyf-tracks ready!

Name Link
🔨 Latest commit ce1455f
🔍 Latest deploy log https://app.netlify.com/sites/cyf-tracks/deploys/677284c4fbfbfd0008027135
😎 Deploy Preview https://deploy-preview-1275--cyf-tracks.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 30, 2024

Deploy Preview for cyf-curriculum canceled.

Name Link
🔨 Latest commit ce1455f
🔍 Latest deploy log https://app.netlify.com/sites/cyf-curriculum/deploys/677284c44a8c1f0008dfbe2a

Copy link

netlify bot commented Dec 30, 2024

Deploy Preview for cyf-piscine ready!

Name Link
🔨 Latest commit ce1455f
🔍 Latest deploy log https://app.netlify.com/sites/cyf-piscine/deploys/677284c4e219f400087c9472
😎 Deploy Preview https://deploy-preview-1275--cyf-piscine.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 85 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 30, 2024

Deploy Preview for cyf-itd ready!

Name Link
🔨 Latest commit ce1455f
🔍 Latest deploy log https://app.netlify.com/sites/cyf-itd/deploys/677284c472096200081c2735
😎 Deploy Preview https://deploy-preview-1275--cyf-itd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 97 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 30, 2024

Deploy Preview for cyf-common ready!

Name Link
🔨 Latest commit ce1455f
🔍 Latest deploy log https://app.netlify.com/sites/cyf-common/deploys/677284c40d5b8a000819cec1
😎 Deploy Preview https://deploy-preview-1275--cyf-common.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SallyMcGrath SallyMcGrath merged commit 0267af4 into main Dec 30, 2024
34 checks passed
@SallyMcGrath SallyMcGrath deleted the content/success-criteria-reductions branch December 30, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👀 Review Requirements Changes requested to meet requirements
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants