Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: cleanup after tabs work #1281

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Fix: cleanup after tabs work #1281

merged 1 commit into from
Jan 2, 2025

Conversation

SallyMcGrath
Copy link
Member

@SallyMcGrath SallyMcGrath commented Jan 2, 2025

this one was missed somehow so is breaking data-groups/sprints/2/prep/#access-with-variables

Have searched and found no more

#1268

data-groups/sprints/2/prep/#access-with-variables
Copy link

netlify bot commented Jan 2, 2025

Deploy Preview for cyf-sdc ready!

Name Link
🔨 Latest commit 47e5b2e
🔍 Latest deploy log https://app.netlify.com/sites/cyf-sdc/deploys/6776937af5b3ac000836210c
😎 Deploy Preview https://deploy-preview-1281--cyf-sdc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 2, 2025

Deploy Preview for cyf-common ready!

Name Link
🔨 Latest commit 47e5b2e
🔍 Latest deploy log https://app.netlify.com/sites/cyf-common/deploys/6776937ae41dee000823e170
😎 Deploy Preview https://deploy-preview-1281--cyf-common.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 2, 2025

Deploy Preview for cyf-curriculum canceled.

Name Link
🔨 Latest commit 47e5b2e
🔍 Latest deploy log https://app.netlify.com/sites/cyf-curriculum/deploys/6776937ae219f400084bb1d1

Copy link

netlify bot commented Jan 2, 2025

Deploy Preview for cyf-tracks ready!

Name Link
🔨 Latest commit 47e5b2e
🔍 Latest deploy log https://app.netlify.com/sites/cyf-tracks/deploys/6776937ab88d110008072aa6
😎 Deploy Preview https://deploy-preview-1281--cyf-tracks.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SallyMcGrath SallyMcGrath changed the title cleanup after tabs work Fix: cleanup after tabs work Jan 2, 2025
Copy link

netlify bot commented Jan 2, 2025

Deploy Preview for cyf-programming ready!

Name Link
🔨 Latest commit 47e5b2e
🔍 Latest deploy log https://app.netlify.com/sites/cyf-programming/deploys/6776937a6cfcc60008ee6a8b
😎 Deploy Preview https://deploy-preview-1281--cyf-programming.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 83 (🔴 down 13 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 2, 2025

Deploy Preview for cyf-itd ready!

Name Link
🔨 Latest commit 47e5b2e
🔍 Latest deploy log https://app.netlify.com/sites/cyf-itd/deploys/6776937a9606b50008a65953
😎 Deploy Preview https://deploy-preview-1281--cyf-itd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 85 (🔴 down 6 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird 😂

Copy link

netlify bot commented Jan 2, 2025

Deploy Preview for cyf-launch ready!

Name Link
🔨 Latest commit 47e5b2e
🔍 Latest deploy log https://app.netlify.com/sites/cyf-launch/deploys/6776937a0815e200087f0c3e
😎 Deploy Preview https://deploy-preview-1281--cyf-launch.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 2, 2025

Deploy Preview for cyf-piscine ready!

Name Link
🔨 Latest commit 47e5b2e
🔍 Latest deploy log https://app.netlify.com/sites/cyf-piscine/deploys/6776937a7158020008adc6c6
😎 Deploy Preview https://deploy-preview-1281--cyf-piscine.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 77 (🔴 down 19 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@SallyMcGrath SallyMcGrath merged commit 845e494 into main Jan 2, 2025
34 checks passed
@SallyMcGrath SallyMcGrath deleted the fix/regex-casualties branch January 2, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants