Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give friendly error on empty backlog repo #1294

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Conversation

illicitonion
Copy link
Member

Currently you get a complicated error about a nil dereference. This makes it clear what happened.

Copy link

netlify bot commented Jan 9, 2025

Deploy Preview for cyf-curriculum canceled.

Name Link
🔨 Latest commit 3d9946a
🔍 Latest deploy log https://app.netlify.com/sites/cyf-curriculum/deploys/678151541f70ed00082554aa

Copy link

netlify bot commented Jan 9, 2025

Deploy Preview for cyf-programming ready!

Name Link
🔨 Latest commit 3d9946a
🔍 Latest deploy log https://app.netlify.com/sites/cyf-programming/deploys/678151540971b80008653b14
😎 Deploy Preview https://deploy-preview-1294--cyf-programming.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 95 (🟢 up 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 9, 2025

Deploy Preview for cyf-common ready!

Name Link
🔨 Latest commit 3d9946a
🔍 Latest deploy log https://app.netlify.com/sites/cyf-common/deploys/678151549c40c50008e8779c
😎 Deploy Preview https://deploy-preview-1294--cyf-common.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 9, 2025

Deploy Preview for cyf-sdc ready!

Name Link
🔨 Latest commit 3d9946a
🔍 Latest deploy log https://app.netlify.com/sites/cyf-sdc/deploys/67815154eae0520008410b30
😎 Deploy Preview https://deploy-preview-1294--cyf-sdc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 9, 2025

Deploy Preview for cyf-launch ready!

Name Link
🔨 Latest commit 3d9946a
🔍 Latest deploy log https://app.netlify.com/sites/cyf-launch/deploys/678151547969980008389a92
😎 Deploy Preview https://deploy-preview-1294--cyf-launch.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 9, 2025

Deploy Preview for cyf-tracks ready!

Name Link
🔨 Latest commit 3d9946a
🔍 Latest deploy log https://app.netlify.com/sites/cyf-tracks/deploys/678151547969980008389a96
😎 Deploy Preview https://deploy-preview-1294--cyf-tracks.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 9, 2025

Deploy Preview for cyf-itd ready!

Name Link
🔨 Latest commit 3d9946a
🔍 Latest deploy log https://app.netlify.com/sites/cyf-itd/deploys/678151549c40c50008e877a1
😎 Deploy Preview https://deploy-preview-1294--cyf-itd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 85 (🔴 down 3 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 9, 2025

Deploy Preview for cyf-piscine ready!

Name Link
🔨 Latest commit 3d9946a
🔍 Latest deploy log https://app.netlify.com/sites/cyf-piscine/deploys/67815154eae0520008410b34
😎 Deploy Preview https://deploy-preview-1294--cyf-piscine.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 85 (🔴 down 12 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Currently you get a complicated error about a nil dereference. This
makes it clear what happened.
Copy link
Member

@SallyMcGrath SallyMcGrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with this but tbh thought it did warn already? It comes up in yellow? But happy for this!

@illicitonion illicitonion merged commit 25cece4 into main Jan 13, 2025
34 checks passed
@illicitonion illicitonion deleted the no-issues-error branch January 13, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants