Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

day plan with proposed workshop #400

Merged
merged 1 commit into from
Dec 1, 2023
Merged

day plan with proposed workshop #400

merged 1 commit into from
Dec 1, 2023

Conversation

SallyMcGrath
Copy link
Member

@SallyMcGrath SallyMcGrath commented Nov 27, 2023

What does this change?

Module: JS3
Week(s): 3

Checklist

Description

Dayplan for JS3 with debugging workshop, that must be merged before this one can be CodeYourFuture/CYF-Workshops#164

Please review that workshop and merge it, then merge this one . This PR is blocked by CodeYourFuture/CYF-Workshops#164

Who needs to know about this?

Copy link

netlify bot commented Nov 27, 2023

Deploy Preview for cyf-curriculum ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/cyf-curriculum/deploys/656a5c7419315a4b721c95a2
😎 Deploy Preview https://deploy-preview-400--cyf-curriculum.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SallyMcGrath SallyMcGrath added this to the JS3 milestone Nov 28, 2023
@SallyMcGrath SallyMcGrath self-assigned this Nov 28, 2023
@SallyMcGrath SallyMcGrath marked this pull request as ready for review November 30, 2023 22:18
@SallyMcGrath SallyMcGrath added the blocked Blocked by something explained in comments label Nov 30, 2023
Copy link
Contributor

@40thieves 40thieves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I think - pretty sure the build is failing because this depends on CodeYourFuture/CYF-Workshops#164

@40thieves
Copy link
Contributor

I rebuilt the branch on Netlify (successfully), but I guess it doesn't update the Github PR status? I'm going to abuse my privileges again and go ahead and merge this.

@40thieves 40thieves merged commit f4ffe6b into main Dec 1, 2023
@40thieves 40thieves deleted the content/js3/dayplan/3 branch December 1, 2023 22:28
@SallyMcGrath SallyMcGrath removed the blocked Blocked by something explained in comments label Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants