Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add evaluate block #544

Merged
merged 13 commits into from
Jan 27, 2024
Merged

add evaluate block #544

merged 13 commits into from
Jan 27, 2024

Conversation

Dedekind561
Copy link
Contributor

What does this change?

Module: JS3
Week(s): 1

Checklist

Description

Copy link

netlify bot commented Jan 24, 2024

Deploy Preview for cyf-curriculum ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/cyf-curriculum/deploys/65b4d50b213eee7bc580d398
😎 Deploy Preview https://deploy-preview-544--cyf-curriculum.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Dedekind561 Dedekind561 changed the title add sketch of evaluate block add evaluate block Jan 24, 2024
Copy link
Member

@SallyMcGrath SallyMcGrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes but otherwise great idea

common-content/en/blocks/evaluate/index.md Outdated Show resolved Hide resolved
common-content/en/blocks/evaluate/index.md Outdated Show resolved Hide resolved
common-content/en/blocks/evaluate/index.md Outdated Show resolved Hide resolved
common-content/en/blocks/evaluate/index.md Outdated Show resolved Hide resolved
common-content/en/blocks/evaluate/index.md Outdated Show resolved Hide resolved
Copy link
Member

@SallyMcGrath SallyMcGrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple more comments sorry


## Activity

1. Go back to JS1 Week 4 prep and familiarise yourself with the problem/function in that week
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could decouple this further by just creating this as a general block. Instead of saying go back to JS1 W4, could you say go back 2 modules and find a problem?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm connecting this to the spaced repetition block I made. (Look in HTML-CSS)

You could even pair it with one of those

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did think about the generality here: ideally I wanted to be able to pass a reference to a particular problem as an argument but I think that saying 2 modules ago will be cool too

@Dedekind561 Dedekind561 merged commit 2c0995d into main Jan 27, 2024
6 checks passed
@Dedekind561 Dedekind561 deleted the add-evaluate-block branch January 27, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants