Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix environment setup in new structure #546

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

sztupy
Copy link
Contributor

@sztupy sztupy commented Jan 25, 2024

The GITHUB TOKEN's environment name has changed recently but this was not reflected in the readme and the .env configs. This change also makes sure that the .env file values are proeprly picked up, and that the README is updated to help new users be able to set up their local dev environment quicker

The GITHUB TOKEN's environment name has changed recently but this was not reflected in the readme and the .env configs. This change also makes sure that the .env file values are proeprly picked up, and that the README is updated to help new users be able to set up their local dev environment quicker
Copy link

netlify bot commented Jan 25, 2024

Deploy Preview for cyf-curriculum ready!

Name Link
🔨 Latest commit 519b5f5
🔍 Latest deploy log https://app.netlify.com/sites/cyf-curriculum/deploys/65b23d4953db1d0008a8b2a3
😎 Deploy Preview https://deploy-preview-546--cyf-curriculum.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 86 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@SallyMcGrath SallyMcGrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ❤️

@SallyMcGrath SallyMcGrath merged commit 22948a3 into CodeYourFuture:main Jan 26, 2024
6 checks passed
sztupy added a commit to sztupy/curriculum that referenced this pull request Jan 27, 2024
…tion

* origin/main: (32 commits)
  refer to the problem from 2 modules ago
  add retro to js3 sprint 1
  add morning orientation to js3 sprint 4
  Update common-content/en/blocks/evaluate/index.md
  Update common-content/en/blocks/evaluate/index.md
  Update common-content/en/blocks/evaluate/index.md
  Update common-content/en/blocks/evaluate/index.md
  Update common-content/en/blocks/evaluate/index.md
  tweak timings
  fix closing shortcode
  Update common-content/en/module/js3/diagnose/index.md
  Update common-content/en/module/js3/diagnose/index.md
  Update common-content/en/module/js3/diagnose/index.md
  Fix environment setup in new structure (CodeYourFuture#546)
  missing config on org-cyf to match common-theme (CodeYourFuture#550)
  common-theme is missing its config (CodeYourFuture#549)
  add note on planning during the week
  add step about checking the module success criteria
  add setup and refer to learning objectives
  change heading level
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants