Add general notes for deployments #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For more info see CodeYourFuture#515 This is splitting out that PR into multiple parts. This is part 1 - the core description for deployments
❌ Deploy Preview for cyf-curriculum failed.
|
|
Build fails as it requires the subdirectories to be present as well due to links: |
|
@sztupy Your deploy preview isn't building here - how are you planning on linking to these pages on the /guides page? |
👷 Deploy request for curriculum-docs pending review.Visit the deploys page to approve it
|
|
@sztupy I've fixed the issue - you were using incorrect links to point to the netlify guide. Now it is building properly! 😄 |
Dedekind561
approved these changes
Mar 12, 2024
There was a problem hiding this comment.
@sztupy Thanks for setting up this guide - and splitting up the PRs!
Let's get this merged and we can start iterating from there...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For more info see #515
This is splitting out that PR into multiple parts. This is part 1 - the core description for deployments
See also