Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

586 Launch content isn't showing on Curriculum #592

Merged
merged 2 commits into from
Feb 16, 2024
Merged

Conversation

SallyMcGrath
Copy link
Member

@SallyMcGrath SallyMcGrath commented Feb 16, 2024

  1. Restore the Launch links which got overwritten when we did the mega merge. This is because these PRs were merged in during the changeover - bad timing. Fixes Launch content isn't showing on Curriculum #586

  2. Also restored the old emoji as the staring girl alarmed me.

  3. Added short descriptions which can be edited

  4. I'm not keen on these mega tabs. Can we perhaps use issues here? Or local blocks? The tabbed view as the only view seems hard to read. We can add specific issues to the prep view and use those tabs.

  5. It seems like entry criteria should go in module/prep and exit criteria in module/success now we have those things

I'm not loving these mega tabs. Can we move some of this content into either tickets or local blocks?
Copy link

netlify bot commented Feb 16, 2024

Deploy Preview for cyf-curriculum ready!

Name Link
🔨 Latest commit 609c906
🔍 Latest deploy log https://app.netlify.com/sites/cyf-curriculum/deploys/65cf74a06edfa900080f4a87
😎 Deploy Preview https://deploy-preview-592--cyf-curriculum.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 98 (🟢 up 6 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@SallyMcGrath SallyMcGrath added the ⚙️ bug Something isn't working label Feb 16, 2024
@kfklein15
Copy link
Contributor

Thanks, looks ok. I'll raise ticket for other requests on this PR.

@kfklein15 kfklein15 merged commit 06582ee into main Feb 16, 2024
6 checks passed
@kfklein15 kfklein15 deleted the bugfix/586-the-launch branch February 16, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Launch content isn't showing on Curriculum
2 participants