Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ Content: Common Content mass front matter change #845

Merged
merged 7 commits into from
Aug 4, 2024

Conversation

SallyMcGrath
Copy link
Member

@SallyMcGrath SallyMcGrath commented Aug 2, 2024

What does this change?

  1. Change all instances of headless=true in blocks front matter to
[build]
    render = false
    list = 'local'
    publishResources = false

https://gohugo.io/content-management/build-options/

  1. Add an index file to each folder, so these can show on common-docs block viewer

Common Content?

Yes ALL blocks in common content

This is part 2 of 3 linked PRS

#844 <== common-theme changes
#845 <== common-content changes
#846 <== common-docs site created

headless="true"

to
[build]
    render = false
    list = 'local'
    publishResources = false
Copy link

netlify bot commented Aug 2, 2024

Deploy Preview for cyf-curriculum ready!

Name Link
🔨 Latest commit eab35b8
🔍 Latest deploy log https://app.netlify.com/sites/cyf-curriculum/deploys/66af408b1d61f90008ce8502
😎 Deploy Preview https://deploy-preview-845--cyf-curriculum.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Aug 2, 2024

Deploy Preview for cyf-sdc canceled.

Name Link
🔨 Latest commit eab35b8
🔍 Latest deploy log https://app.netlify.com/sites/cyf-sdc/deploys/66af408b5280c400085757a9

Copy link

netlify bot commented Aug 2, 2024

Deploy Preview for cyf-programming ready!

Name Link
🔨 Latest commit eab35b8
🔍 Latest deploy log https://app.netlify.com/sites/cyf-programming/deploys/66af408b2ebedb0008d5967e
😎 Deploy Preview https://deploy-preview-845--cyf-programming.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

This was referenced Aug 2, 2024
Copy link
Member

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels like there are two useful tests we could automate here:

  1. Pages which should have the [build] section you've inserted have it
  2. ?Every directory has an index of some description

Once I address #696 and get it merged, I'd be very happy to either write these checks, or pair with you to do so; can we try to enumerate the conditions where each is expected/required?

@SallyMcGrath SallyMcGrath self-assigned this Aug 3, 2024
@SallyMcGrath
Copy link
Member Author

It feels like there are two useful tests we could automate here:

  1. Pages which should have the [build] section you've inserted have it
  2. ?Every directory has an index of some description

Once I address #696 and get it merged, I'd be very happy to either write these checks, or pair with you to do so; can we try to enumerate the conditions where each is expected/required?

Yes to this - yes please!

I just feel exhausted at the idea of updating these files (i'm no good at regex) so I might need to work up the energy for it first

@SallyMcGrath SallyMcGrath merged commit 1318549 into main Aug 4, 2024
14 checks passed
@SallyMcGrath SallyMcGrath deleted the feature/cc-build-settings branch August 4, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants