This repository has been archived by the owner on Oct 2, 2024. It is now read-only.
London-10_Olha-Danylevska_Node-Module_quote-server #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llamojha
reviewed
Jul 29, 2023
| }) | ||
|
|
||
| app.get("/quotes/search", (request, response) => { | ||
| let word = request.query.terms |
There was a problem hiding this comment.
Overall the code is good so I just have a small comment: Keep the consistency in the naming. For example, in this case, you have 'query.terms' assigned to 'word'. But then at the function, searchTheQuote is using 'term'. 3 different names for the same content.
A good example is the /echo endpoint. Where the query.word is assigned to word, so both of them keep the consistency on the naming.
There was a problem hiding this comment.
Thank you very much Alvaro, will do it in the future!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
What did you find hard?
What do you still not understand?
Any other notes?