Fix support for doctrine/dbal v2 #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
W0rma
commented
Jul 29, 2024
| @@ -71,7 +71,12 @@ protected function _setUp() | |||
| require_once $dir . "/CircularRelations/C.php"; | |||
| require_once $dir . '/EntityWithUuid.php'; | |||
|
|
|||
| $connection = DriverManager::getConnection(['driver' => 'sqlite3', 'memory' => true]); | |||
| $sqliteDriver = 'sqlite3'; | |||
| if (version_compare(InstalledVersions::getVersion('doctrine/orm'), '3.5', '<')) { | |||
There was a problem hiding this comment.
The driver "sqlite3" was added in https://github.com/doctrine/dbal/releases/tag/3.5.0
There was a problem hiding this comment.
is this change really related to the issue?
Why is this necessary?
There was a problem hiding this comment.
Yes, it is related since without this change tests would fail if DBAL < 3.5 is installed because the "sqlite3" driver was added in DBAL v3.5.
However, I noticed that I mixed up the package names.
I fixed the version check.
W0rma
force-pushed
the
dbal2
branch
2 times, most recently
from
d86e9ca to
97d2570
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30