Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make --type option optional with clear_cache command #858

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

carlalexander
Copy link
Collaborator

Small fix to the clear_cache command that I found fixing an issue for a client. It says --type defaults to images, but that doesn't work in practice.

image

@carlalexander carlalexander requested a review from selul November 25, 2024 19:06
@carlalexander
Copy link
Collaborator Author

One quick question is should we change type to be images instead of ''. Otherwise, the success message doesn't work.

@pirate-bot
Copy link
Collaborator

Plugin build for e8e2a1b is ready 🛎️!

@selul
Copy link
Contributor

selul commented Nov 26, 2024

oh, you are right, thank you @carlalexander 🚀

@selul selul changed the base branch from master to development November 26, 2024 07:15
@selul selul merged commit 046aaab into development Nov 26, 2024
11 of 12 checks passed
@selul selul deleted the carlalexander-clear-cache-fix branch November 26, 2024 07:21
@pirate-bot
Copy link
Collaborator

🎉 This PR is included in version 3.13.9 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants