-
Notifications
You must be signed in to change notification settings - Fork 72
Fixes around strings. #333
base: development
Are you sure you want to change the base?
Conversation
If parameter text is not readable, translate will change. If you don't need to add screen-reader-text, that's better to remove.
@mayukojpn hey there, thanks again for help! I think the screen-reader-text things are required for accessibility purpose. |
Also we might take some time to merge this since we are planning to merge all string related things once in few months :) |
This reverts commit 1a179da.
OK, I cancelled these fixes :) In this case, I'd like to translatie both "Install %s now" and "Install Now". If there are no theme name, we should remove particle (Like to, on, in ...) |
yep got it, however just a general thought, I don't think we should have product names translatable, I mean Zerif Lite for example is a brand and a trademark, you don't translate that. I mean do you translate WordPress in other languages? In romanian would be : cuvantpresa 👯 |
No, we don't translate WordPress. Sometimes we translate theme/plugin name depending on author's request, but these are rare. Sometimes we write WordPress as "ワードプレス", but pronunciation is almost same (a bit harder sound 😃). |
No description provided.