Skip to content
This repository has been archived by the owner on May 5, 2021. It is now read-only.

Fixes around strings. #333

Open
wants to merge 7 commits into
base: development
Choose a base branch
from

Conversation

mayukojpn
Copy link
Contributor

No description provided.

@ineagu
Copy link
Contributor

ineagu commented Apr 18, 2016

@mayukojpn hey there, thanks again for help! I think the screen-reader-text things are required for accessibility purpose.

@ineagu
Copy link
Contributor

ineagu commented Apr 18, 2016

Also we might take some time to merge this since we are planning to merge all string related things once in few months :)

@mayukojpn
Copy link
Contributor Author

OK, I cancelled these fixes :)

In this case, I'd like to translatie both "Install %s now" and "Install Now". If there are no theme name, we should remove particle (Like to, on, in ...)

@ineagu
Copy link
Contributor

ineagu commented Apr 18, 2016

yep got it, however just a general thought, I don't think we should have product names translatable, I mean Zerif Lite for example is a brand and a trademark, you don't translate that.

I mean do you translate WordPress in other languages? In romanian would be : cuvantpresa 👯

@mayukojpn
Copy link
Contributor Author

No, we don't translate WordPress. Sometimes we translate theme/plugin name depending on author's request, but these are rare.

Sometimes we write WordPress as "ワードプレス", but pronunciation is almost same (a bit harder sound 😃).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants