Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backend Test submission - Python/Django role #37

Open
wants to merge 29 commits into
base: main
Choose a base branch
from
Open

Backend Test submission - Python/Django role #37

wants to merge 29 commits into from

Conversation

jppradoleal
Copy link

Some notes about the submission.

  • There are some warnings from Django, they're primarily future deprecation warnings, about things that are coming in Django 5.
  • DRF also complains about PAGE_SIZE being defined while DEFAULT_PAGINATION_CLASS isn't, there are no problems with that.
  • During development there were significant changes in compound interest calc, moving from query logic to model property, they were motivated mostly by the query complexity.

jppradoleal and others added 29 commits August 15, 2022 16:10
@jppradoleal
feat: init django server
204ef91
@jppradoleal
feat: configures db, app and debugpy through Docker
cc68975
@jppradoleal
feat: creates investment model
af9f609
@jppradoleal
feat: configures pytest
0b789a8
@jppradoleal
feat: configures drf; fix: returns with debugpy
37e02a8
@jppradoleal
feat: adds user CRUD
6536784
@jppradoleal
feat: configures swagger through drf-yasg
5a8f3ff
@jppradoleal
test: fixes pytest config
bc2bda0
@jppradoleal
test: tests for user
8a5261f
@jppradoleal
feat: moves investment to its on app
dcdbb0d
@jppradoleal
feat: basic http verbs for investments
dec595e
@jppradoleal
feat: improves user viewset
882b920
@jppradoleal
feat: list gains on investments list
a21a4f9
@jppradoleal
feat: basic withdrawal action
aab907a
@jppradoleal
refact: moves common fixtures to conftest
e378223 
feat: moves balance logic to model property

fix: changes success status code for withdrawn action

test: implements tests for investment views
@jppradoleal
style: applies black formatter
b1fa117
@jppradoleal
feat: fixes date validation for withdrawn action
328bcf4 
fix: removes trailing slash from urls

tests: update tests
@jppradoleal
fix: fix compound interest formula
7532769
@jppradoleal
ci: initial config
f7f82ff
@jppradoleal
docs: fixes typo and adds pytest-xdist entry
f2eb748 
docs: updates style and some spelling mistakes
@jppradoleal
feat: adds db_driver env and removes month division on interest_svc
d03ce55 
feat: adds wait-for-it instruction to avoid db starting after webserver
@jppradoleal
feat: configures celery
226c9ce
@jppradoleal
fix: fixes querysets that filters by user
2fc72a0 
refact: removes unused files

fix: returns with trailing slash (it was breaking the openapi specs, for
some reason)

feat: adds mailing when doing a withdrawn
@jppradoleal
test: mocks celery task
8fd8c04
@jppradoleal
feat: changes amount float field to decimal field as it's more suitab…
4389cf9 
…le for money
@jppradoleal
docs: updates README.MD
786d9a0
@jppradoleal
docs: updates compound gain formula
ae2684c
@jppradoleal
test: updates investment tests
6cc988d
@jppradoleal
Merge branch 'development' of github.com:jppradoleal/backend-test-cod…
6836653 
…erockr into development
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jppradoleal