Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker so the app waits for mongo #39

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

brilvio
Copy link

@brilvio brilvio commented Jul 15, 2020

Sorry to hijack and fix the issue, but I had this problem before.

Now looking at the issue it has has nothing to do with waiting for mongo to start, but still you can see the implementation here.

It uses this implementation https://github.com/ufoscout/docker-compose-wait/

@brilvio brilvio mentioned this pull request Jul 15, 2020
6 tasks
@w3cj
Copy link
Member

w3cj commented Aug 1, 2020

Fails to connect and then kills api container on Mac. Tried specifying some env vars to change the timeout / max failures, but no luck.

@brilvio
Copy link
Author

brilvio commented Aug 3, 2020

I will test on linux to see if works and get back to you.

- Changed the CMD on `Dockerfile`
@brilvio
Copy link
Author

brilvio commented Aug 3, 2020

Fails to connect and then kills api container on Mac. Tried specifying some env vars to change the timeout / max failures, but no luck.

It was failing for me as well, it was connecting but then it would exit out of the container.

I updated the version of docker-compose-wait and changed the CMD line on Dockerfile the old way only run the /wait command, sorry for not testing I was using windows when I made the changes.

Now I did test on linux Ubuntu and it is working as intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants