Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start on supporting checking for online status of Twitch Teams #5972

Open
wants to merge 9 commits into
base: V3/develop
Choose a base branch
from

Conversation

palmtree5
Copy link
Member

Description of the changes

Adds support for checking the online status of a Twitch Team (more specifically: it will display the team's info and generate online stream embeds for members of the team that are online, while NOT displaying the offline members). Resolves #2157 and I went with the option of minimizing the number of requests being made to Twitch's API (i.e. one request to get the team data, one request for every 100 team members' user data, one request for every 100 team members' stream data (which offline users do not show up in), and one request per user for their current follower count). This also makes a few changes to other classes, including implementing a TwitchMeta class, which is a subclass of Stream, but which has TwitchStream and TwitchTeam as subclasses (this is mainly to just put the handling of API calls for Twitch in one place), and changing make_embed in TwitchStream to be a staticmethod as it is the format I wanted for the online user embeds.

Note that the actual Discord command has not been written yet, but that's ultimately the easier part. I also need to have it generate the embed with the data for the team itself as that should be displayed every time.

Have the changes in this PR been tested?

Somewhat, as I definitely have it at the point of being able to list out online team members, but there are other pieces not written yet, hence the draft status for the moment

Yes
No

@palmtree5 palmtree5 added Type: Enhancement Something meant to enhance existing Red features. Category: Cogs - Streams This is related to the Streams cog. labels Jan 16, 2023
@palmtree5 palmtree5 added this to the 3.6.0 milestone Feb 15, 2023
@palmtree5
Copy link
Member Author

Update on this: [p]twitchteam has been added in and has been confirmed working. The output from that command comes in the form of two messages: one for the team info, and a reaction menu for the team members currently online.

I am not sure if we want to pursue stream alerts for Twitch teams though as I am quite honestly not sure how I would want to proceed on that front

@palmtree5 palmtree5 marked this pull request as ready for review April 1, 2024 01:33
@palmtree5
Copy link
Member Author

This PR should be ready to test. Will be holding off on trying to do any sort of stream alerts for Twitch Teams for the time being (I.e. that will be a separate PR if it gets written)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Cogs - Streams This is related to the Streams cog. Type: Enhancement Something meant to enhance existing Red features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[V3 Streams] add support for Twitch teams
1 participant