Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a start_dm option to SimpleMenu #6286

Merged
merged 6 commits into from
Jan 15, 2024

Conversation

yeetbruises
Copy link
Contributor

@yeetbruises yeetbruises commented Jan 14, 2024

Description of the changes

Have the changes in this PR been tested?

Yes

I tested the method by making changes to "help.py" under the send_pages() method.

The image below shows the modified code in that file.

Screenshot 2024-01-14 at 5 15 57 PM

DM result

Screenshot 2024-01-14 at 5 18 12 PM

@github-actions github-actions bot added Category: Core - API - Utils Package This is related to stuff in `redbot.core.utils` Category: Meta This is related to the repository maintenance. labels Jan 14, 2024
@github-actions github-actions bot removed the Category: Meta This is related to the repository maintenance. label Jan 14, 2024
@yeetbruises yeetbruises changed the title Add a start_dm option to SimpleMenu - #6282 Add a start_dm option to SimpleMenu Jan 14, 2024
@Flame442 Flame442 added the Type: Enhancement Something meant to enhance existing Red features. label Jan 15, 2024
Copy link
Member

@Flame442 Flame442 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

As an FYI, the example screenshot of your testing had a line get_user = ctx.bot.get_user(ctx.author.id). ctx.author is already a User object (even if used in a guild, since the Member object you will get is a subclass of User), so you don't need the extra cache lookup in that case.

@Flame442 Flame442 merged commit 409ece4 into Cog-Creators:V3/develop Jan 15, 2024
18 checks passed
@Flame442 Flame442 added this to the 3.5.6 milestone Jan 15, 2024
@red-githubbot red-githubbot bot added the Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. label Jan 15, 2024
@Jackenmen Jackenmen added Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. and removed Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. labels Mar 22, 2024
Dav-Git pushed a commit to Dav-Git/Red-DiscordBot that referenced this pull request Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Core - API - Utils Package This is related to stuff in `redbot.core.utils` Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. Type: Enhancement Something meant to enhance existing Red features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a start_dm option to SimpleMenu
3 participants