Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Audio] Update Lavalink.jar build #6305

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

aikaterna
Copy link
Member

Description of the changes

This changes audio's manager to download and use version 3.7.11 of our Lavalink.jar.

Have the changes in this PR been tested?

No.

Lavalink changelog:

Fixed not being able to seek when player is paused
Updated Oshi to 6.4.3
Updated Lavaplayer to 1.5.3
Resolved some 400 errors during yt and ytm playback

@aikaterna aikaterna added Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing. Type: Dependency Update Adding/updating/removing some of Red’s dependencies. Category: Cogs - Audio This is related to the Audio cog. labels Mar 10, 2024
@aikaterna aikaterna added this to the 3.5.6 milestone Mar 10, 2024
@aikaterna aikaterna requested a review from PredaaA as a code owner March 10, 2024 23:51
@aikaterna aikaterna changed the title Update Lavalink.jar build [Audio] Update Lavalink.jar build Mar 10, 2024
@tjc15b
Copy link

tjc15b commented Mar 16, 2024

Trying to run your branch locally, but the lavalink.jar download gets killed after 56 seconds:

image

Any ideas? I was trying to get this youtube music fix in without waiting for full release :D

@aikaterna
Copy link
Member Author

Trying to run your branch locally, but the lavalink.jar download gets killed after 56 seconds:

image

Any ideas? I was trying to get this youtube music fix in without waiting for full release :D

Seems like you have some issues with your network or whatever you are trying. If you need help, visit the #support channel in Discord, discord.gg/red

@tjc15b
Copy link

tjc15b commented Mar 16, 2024

Trying to run your branch locally, but the lavalink.jar download gets killed after 56 seconds:
image
Any ideas? I was trying to get this youtube music fix in without waiting for full release :D

Seems like you have some issues with your network or whatever you are trying. If you need help, visit the #support channel in Discord, discord.gg/red

I got it working by going back to the 3.5.5 release build and replacing my Lavalink.jar manually with 3.7.11

@ja-cop
Copy link

ja-cop commented Mar 17, 2024

There is also a Lavalink v4.0.4/Lavaplayer v2.1.1 now, with further fixes for the 400 error response 🙂

@aikaterna
Copy link
Member Author

There is also a Lavalink v4.0.4/Lavaplayer v2.1.1 now, with further fixes for the 400 error response 🙂

We don't use Lavalink v4 here, but the v3 version we're using has these fixes you're speaking of, backported to the appropriate Lavalink and Lavaplayer legacy versions.

Copy link
Member

@Jackenmen Jackenmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jackenmen Jackenmen merged commit 3a81e83 into Cog-Creators:V3/develop Mar 18, 2024
20 checks passed
@red-githubbot red-githubbot bot added the Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. label Mar 18, 2024
@Jackenmen Jackenmen added Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. and removed Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. labels Mar 22, 2024
Dav-Git pushed a commit to Dav-Git/Red-DiscordBot that referenced this pull request Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Cogs - Audio This is related to the Audio cog. Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing. Type: Dependency Update Adding/updating/removing some of Red’s dependencies.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants