Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove traceback suppression from buttonized menu() #6310

Merged

Conversation

Jackenmen
Copy link
Member

@Jackenmen Jackenmen commented Mar 17, 2024

Description of the changes

With this change, incorrect menu() action implementations will now properly log the traceback for buttonized ([p]set usebuttons 1) menus:
image

Have the changes in this PR been tested?

Yes

@Jackenmen Jackenmen added this to the 3.5.6 milestone Mar 17, 2024
@Jackenmen Jackenmen requested a review from Flame442 March 17, 2024 22:37
@github-actions github-actions bot added the Category: Core - API - Utils Package This is related to stuff in `redbot.core.utils` label Mar 17, 2024
@Jackenmen Jackenmen added the Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing. label Mar 17, 2024
@Flame442 Flame442 self-assigned this Mar 17, 2024
@Flame442 Flame442 merged commit 293d806 into Cog-Creators:V3/develop Mar 17, 2024
18 checks passed
@red-githubbot red-githubbot bot added the Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. label Mar 17, 2024
@Jackenmen Jackenmen deleted the remove_traceback_suppression branch March 18, 2024 05:11
@Jackenmen Jackenmen added Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. and removed Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. labels Mar 22, 2024
Dav-Git pushed a commit to Dav-Git/Red-DiscordBot that referenced this pull request Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Core - API - Utils Package This is related to stuff in `redbot.core.utils` Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants