Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependencies #6312

Merged
merged 11 commits into from
Mar 21, 2024
Merged

Conversation

Jackenmen
Copy link
Member

@Jackenmen Jackenmen commented Mar 21, 2024

Description of the changes

This PR does a few things:

  • drops aiodns dependency
    • While aiohttp does have an aiodns implementation, it has been
      disabling it unconditionally for the last 8 years:
      aio-libs/aiohttp@9fbb7d7
  • bumps all dependencies before release as usual
    • this doesn't include Black 24 bump which affects code style
    • this required setting an upper-bound for pytest-asyncio to 0.21.* (+ pytest <8 due to incompatibility) - there is a known issue with 0.23.* on the upstream side for now
  • updates scripts for generating dependency lists to consider differences between Python versions

Have the changes in this PR been tested?

Partially yes, see results:

Test run of updated install instructions:

@Jackenmen Jackenmen requested a review from Kowlin as a code owner March 21, 2024 02:14
@github-actions github-actions bot added Category: CI This is related to repository's CI configuration. Category: Meta This is related to the repository maintenance. labels Mar 21, 2024
@Jackenmen Jackenmen added the Type: Dependency Update Adding/updating/removing some of Red’s dependencies. label Mar 21, 2024
@Jackenmen

This comment was marked as outdated.

@Jackenmen Jackenmen force-pushed the bump_deps_2024_03_18 branch 2 times, most recently from a257b46 to 9474732 Compare March 21, 2024 02:52
While aiohttp does have an aiodns implementation, it has been
disabling it unconditionally for last 8 years:
aio-libs/aiohttp@9fbb7d7
@Jackenmen Jackenmen force-pushed the bump_deps_2024_03_18 branch from 9474732 to 8baea23 Compare March 21, 2024 02:58
@Jackenmen Jackenmen force-pushed the bump_deps_2024_03_18 branch from 8baea23 to 7707a6e Compare March 21, 2024 03:10
@Jackenmen
Copy link
Member Author

Alright, I figured it out, it had nothing to do with asyncpg and everything to do with the testing framework (or more specifically, pytest-asyncio plugin). I added an upper-bound for relevant packages and we can reevaluate it in the future since it's classified as an upstream issue.

@Flame442 Flame442 added this to the 3.5.6 milestone Mar 21, 2024
@Flame442 Flame442 self-assigned this Mar 21, 2024
Copy link
Member

@Flame442 Flame442 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically it isn't against our version guarantees, but removing dependencies has the potential to break 3rd party cogs. pytz is currently used by at least Trusty and Aika, though both include it in requirements.txt. I didn't do a super exhaustive search, so I don't know if there are others that don't explicitly include it. If that isn't something we are worried about, this can be merged.

@Jackenmen Jackenmen merged commit 273ad14 into Cog-Creators:V3/develop Mar 21, 2024
17 checks passed
@Jackenmen Jackenmen deleted the bump_deps_2024_03_18 branch March 21, 2024 18:28
@red-githubbot red-githubbot bot added the Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. label Mar 21, 2024
@Jackenmen Jackenmen added Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. and removed Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. labels Mar 22, 2024
Dav-Git pushed a commit to Dav-Git/Red-DiscordBot that referenced this pull request Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: CI This is related to repository's CI configuration. Category: Meta This is related to the repository maintenance. Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. Type: Dependency Update Adding/updating/removing some of Red’s dependencies.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants