-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump dependencies #6312
Bump dependencies #6312
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
a257b46
to
9474732
Compare
While aiohttp does have an aiodns implementation, it has been disabling it unconditionally for last 8 years: aio-libs/aiohttp@9fbb7d7
9474732
to
8baea23
Compare
8baea23
to
7707a6e
Compare
Alright, I figured it out, it had nothing to do with asyncpg and everything to do with the testing framework (or more specifically, pytest-asyncio plugin). I added an upper-bound for relevant packages and we can reevaluate it in the future since it's classified as an upstream issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically it isn't against our version guarantees, but removing dependencies has the potential to break 3rd party cogs. pytz
is currently used by at least Trusty and Aika, though both include it in requirements.txt
. I didn't do a super exhaustive search, so I don't know if there are others that don't explicitly include it. If that isn't something we are worried about, this can be merged.
Description of the changes
This PR does a few things:
aiodns
dependencydisabling it unconditionally for the last 8 years:
aio-libs/aiohttp@9fbb7d7
0.21.*
(+ pytest <8 due to incompatibility) - there is a known issue with0.23.*
on the upstream side for nowHave the changes in this PR been tested?
Partially yes, see results:
Test run of updated install instructions: