Fixed [p]ban raising an unhandled error if an ID too large is provided #6486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ching to fit standard Discord ID format. Also switched usage of regex.match to regex.fullmatch so IDs aren't truncated. Should no longer give error in console when using [p]ban with an ID that is too large
github-actions
bot
added
the
Category: Core - API - Commands Package
Jackenmen
requested changes
Dec 24, 2024
There was a problem hiding this comment.
The max length of a snowflake is 20 characters, not 19. The max value is 2**64 - 1 (i.e. UINT64_MAX), not 2 ** 63 - 1 (which would be the max for a signed 64-bit integer).
Please put the max value as a private (prefixed with _) constant at the module-level and define it as 2 ** 64 - 1 rather than as a magic number.
Jackenmen
added
the
Type: Bug
|
Apparently, I need to read the traceback with the API response, not Discord's own documentation... |
Jackenmen
approved these changes
Dec 24, 2024
red-githubbot
bot
added
the
Changelog Entry: Pending
Jackenmen
added
Changelog Entry: Added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
Closes #6431
Added ID validation within RawUserIdConverter, and adjusted Regex matching to fit standard Discord ID format. Also switched usage of regex.match to regex.fullmatch so IDs aren't truncated. Should no longer give error in console when using [p]ban with an ID that is too large.
Have the changes in this PR been tested?
Yes