Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix YouTube upcoming stream's embed not being timezone-agnostic #6527

Merged
merged 1 commit into from
Feb 15, 2025
Merged

Fix YouTube upcoming stream's embed not being timezone-agnostic #6527

merged 1 commit into from
Feb 15, 2025
+1 −1

Conversation

karlsbjorn
Copy link
Contributor

Description of the changes

Fixes #6526 by having the timestamp be in UTC

Have the changes in this PR been tested?

Yes

@github-actions github-actions bot added the Category: Cogs - Streams This is related to the Streams cog. label Feb 15, 2025
Kowlin
Kowlin approved these changes Feb 15, 2025
View reviewed changes
Copy link
Member

@Kowlin Kowlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh, no idea how this was never UTC to begin with, Thanks!

@Kowlin Kowlin merged commit 4558b72 into Cog-Creators:V3/develop Feb 15, 2025
17 checks passed
@red-githubbot red-githubbot bot added the Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. label Feb 15, 2025
@Kowlin Kowlin mentioned this pull request Feb 15, 2025
Closed
@karlsbjorn karlsbjorn deleted the streams-tz branch February 25, 2025 15:35
@Jackenmen Jackenmen modified the milestones: 3.5.17, 3.5.18 Mar 8, 2025
@Jackenmen Jackenmen added Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing. Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. and removed Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. labels Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kowlin Kowlin Kowlin approved these changes

@palmtree5 palmtree5 Awaiting requested review from palmtree5 palmtree5 is a code owner

Assignees
No one assigned
Labels
Category: Cogs - Streams This is related to the Streams cog. Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing.
Projects
None yet
Milestone
3.5.17
Development

Successfully merging this pull request may close these issues.

Streams announcement not taking local timezone into consideration
3 participants
@karlsbjorn @Kowlin @Jackenmen