-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added example #48
Added example #48
Conversation
@@ -0,0 +1,43 @@ | |||
from sioux import remote_pipeline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we create an examples folder/module?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I'm thinking maybe we should make it a iPython notebook. Like all the tutorials and examples can be iPython notebooks. @bhargav comment on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to have ipython notebooks. 👍
How about we change it slightly in this way? What do you think? |
It's doable, I can try that. When you said 3 words, do you mind 3 tokens? I ask about it because punctuations are also counted as tokens, right? |
Yeah tokens should be fine. |
BTW, we shouldn't send everything altogether to the pipeline. We can split based on new lines and tabs, before sending it to the pipeline. |
Also as a general comment, the usage is not easy. We should make it easier to access neighboring tokens somehow. https://github.com/CogComp/sioux/pull/48/files#diff-dc8b50acc65729bc37a3b573f4ab541eR31 Also being able to iterate over a view would be useful IMO. for ner_token in pipeline.get_ner(doc):
print(ner_token['label']) |
Good idea, I can make the class a iterator, then we can get rid of @bhargav how would you want to be easier to access neighboring tokens? If we can iterate the view and find constituent by index, would that be sufficient? I can make the usage simpler by adding corresponding tokens in the constituent (then we have |
@danyaljj Example for the first bullet point in #44
We can close this pr after the example is put in ipython notebook