Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to restore Python 3.8 compatibility #1

Merged
merged 5 commits into from
Jul 3, 2024

Conversation

andrewsoltan
Copy link
Contributor

  1. Revert to old-style typing importing to add Python 3.8 backwards (capitalisation of List and Dict)
  2. Correct parentheses use around file opening command for python 3.8 compatibility

1. Revert to old-style typing importing to add Python 3.8 backwards (capitalisation of List and Dict)
2. Correct parynthesis use around file opening command for python 3.8 compatability
Copy link
Member

@baixiac baixiac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @andrewsoltan, Can you add py38 to this GH workflow and see if the CI works fine? Thanks.

@andrewsoltan
Copy link
Contributor Author

Thanks - have added this to the workflow, I think just waiting on approval to be able to test out the CI

@baixiac
Copy link
Member

baixiac commented Jul 1, 2024

Alright, please rebase the master branch onto your PR branch. It should fix the issue caused by the backward incompatibility of HF transformers, as shown in the earlier GH action run.

@andrewsoltan andrewsoltan changed the base branch from master to medcat_0_3 July 1, 2024 17:05
@andrewsoltan andrewsoltan changed the base branch from medcat_0_3 to master July 1, 2024 19:06
@andrewsoltan
Copy link
Contributor Author

Great, thanks, I've just done that - over to you for approval :)

@baixiac
Copy link
Member

baixiac commented Jul 2, 2024

To make the hashlib calls compatible to py38, can you remove all the occurences of usedforsecurity=False from hashlib.sha1([TARGET], usedforsecurity=False).hexdigest() in "app/processors/metrics_collector.py"?

Remove references to usedforsecurity for hashlib compatiablity
Copy link
Member

@baixiac baixiac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@baixiac baixiac merged commit 063c9b4 into CogStack:master Jul 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants