-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to restore Python 3.8 compatibility #1
Conversation
andrewsoltan
commented
Jun 27, 2024
- Revert to old-style typing importing to add Python 3.8 backwards (capitalisation of List and Dict)
- Correct parentheses use around file opening command for python 3.8 compatibility
1. Revert to old-style typing importing to add Python 3.8 backwards (capitalisation of List and Dict) 2. Correct parynthesis use around file opening command for python 3.8 compatability
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @andrewsoltan, Can you add py38 to this GH workflow and see if the CI works fine? Thanks.
Thanks - have added this to the workflow, I think just waiting on approval to be able to test out the CI |
Alright, please rebase the master branch onto your PR branch. It should fix the issue caused by the backward incompatibility of HF transformers, as shown in the earlier GH action run. |
Update base
Great, thanks, I've just done that - over to you for approval :) |
To make the hashlib calls compatible to py38, can you remove all the occurences of |
Remove references to usedforsecurity for hashlib compatiablity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍