⚡ SVG Sprite를 활용한 SVG 관리 #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
Legitgoons
approved these changes
May 1, 2024
Legitgoons
pushed a commit
that referenced
this pull request
May 4, 2024
- icon sprite 추가 - SVG 컴포넌트화 - 고정 및 반응형 박스 레이아웃 mixin 수정 Closes #22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 이유
#21 이슈 해결
작업 사항
mixin함수 생성현재 width 값은 고정적이나, height의 크기에 맞춰 반응형 레이아웃이 구성되기에 우선적으로 SVG 크기에 대해서는 고정적으로 두었습니다. 하지만 이 부분에 대해서는 디자인 팀과 우선적으로 이야기를 나누어보아야 할 것 같습니다.
리뷰어가 중점적으로 확인해야 하는 부분
SVG Sprite를 만들기 위하여, spritebot를 활용하였습니다. SVG Sprite 및 사용 방법은 SVG 스프라이트 기법으로 사이트 성능 향상시키기(리액트에서 스프라이트 SVG 사용하기)를 참고해보시면 좋을 것 같습니다!
SVG 아이콘을 사용하는 방법에 대해 숙지하였나요?
발견한 이슈