-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ 피드 메인 페이지 로딩 및 에러 처리 #27
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request is automatically being deployed by Amplify Hosting (learn more). |
Legitgoons
approved these changes
May 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고 많으셨습니다. 이미 시연 중 발견된 이슈에 대해서는 추가적으로 작성하지 않았습니다. 혹시 이슈에 추가해야할 부분이 있다면 해주시기 바랍니다. 병합하셔도 좋습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 이유
피드 메인 페이지 Loading 및 Error 처리
작업 사항
1️⃣ 피드 메인 페이지 Loading 처리
2️⃣ 피드 메인 페이지 Error 처리
3️⃣ 기타 설정
리뷰어가 중점적으로 확인해야 하는 부분
의찬님이 중점적으로 확인해주셨으면 하는 부분
해당 PR의 경우, React Query Devtools 및 코드 조작을 통해 확인할 수 있기 때문에 직접 확인부탁드리겠습니다.
재서님이 중점적으로 확인해주셨으면 하는 부분
발견한 이슈