Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚙️ User Mock API 등록 #30

Merged
merged 15 commits into from
May 6, 2024
Merged

⚙️ User Mock API 등록 #30

merged 15 commits into from
May 6, 2024

Conversation

Legitgoons
Copy link
Member

@Legitgoons Legitgoons commented May 5, 2024 •
edited by BangDori
Loading

작업 이유

User API에 대한 Mock API 등록


작업 사항

  • Wiki API Specification 문서에 업로드 되어있는 API를 기반으로 하였습니다.
  • User Interface에 feedCount, followingCount, followerCount를 추가했습니다.
  • ProfileFeed Interface와 Relationship Interface를 구현했습니다.

리뷰어가 중점적으로 확인해야 하는 부분

  • ProfileFeed Interface와 Relationship Interface가 추가된 것을 인지했는지
  • User Interface에 feedCount, followingCount, followerCount가 추가된 것을 인지했는지
  • 구현된 항목들이 API Wiki와 일치하는지
  • userHandler가 정상적으로 구현되었는지

발견한 이슈

Legitgoons added 12 commits May 5, 2024 22:57
@Legitgoons
feat: user.d.ts의 User Interface 수정
4e74336 
누락된 feedCount, followingCount, followerCount와 팔로우 확인에 필요한 relationshipStatus를 추가하였습니다.
@Legitgoons
feat: users mock data 수정
1325217 
interface에 추가된 feedCount, followingCount, followerCount, relationshipStatus를 추가
@Legitgoons
feat: profileFeed.d.ts에 ProfileFeed Interface 구현
1696364
@Legitgoons
feat: profileFeeds mock data 구현
467db36
@Legitgoons
feat: userHandlers 구현
2fe28d6
@Legitgoons
feat: mocking worker에 userHandlers 추가
9f6641f
@Legitgoons
chore: 오타 삭제
4368862
@Legitgoons
feat: ProfileFeed interface 수정
4bd1be0 
wiki에 정의된 api에 알맞게 profileImage -> thubnailImage로 수정
@Legitgoons
feat: const profileFeeds 수정
93e003b 
profileImage -> thubnailImage로 수정
@Legitgoons
feat: Relationship interface 추가
b635863 
팔로우 확인에 사용되는 relationshipStatus값을 가지는 interface입니다.
wiki의 정의대로 User Interface에서 분리하였습니다.
@Legitgoons
feat: relationshipStatus mock data 구현
eb09bb7 
user mock data 내부에 구현되어 있었으나, interface에 따라 분리하였습니다.
@Legitgoons
feat: userHandlers 수정
dc53dfa 
users에서 relationshipStatus를 가져오던 followInfo를 relationshipStatus에서 가져오도록 수정했습니다.
@Legitgoons Legitgoons self-assigned this May 5, 2024
@Legitgoons Legitgoons removed the request for review from psychology50 May 5, 2024 16:34
@aws-amplify-ap-northeast-2 AWS Amplify (ap-northeast-2)
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-30.d37mn03xh3qyyz.amplifyapp.com

BangDori
BangDori requested changes May 5, 2024
View reviewed changes
Copy link
Collaborator

@BangDori BangDori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

컨벤션이 맞지 않는 부분이 있어서 이 부분만 수정해주시면 될 것 같습니다! ㅎㅎ

고생많으셨습니다.

Legitgoons added 3 commits May 6, 2024 15:21
@Legitgoons
feat: RelationshipStatus union type으로 수정
c13fb1b 
단일 변수만 있기에 interface에서 union type으로 수정
이름도 Relationship -> RelationshipStatus로 변경
@Legitgoons
feat: relationshipStatus mock data 수정
a94a48f
@Legitgoons
feat: userHandler내 hasNextPage 변수 이름 수정
cff4bce
BangDori
BangDori approved these changes May 6, 2024
View reviewed changes
Copy link
Collaborator

@BangDori BangDori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다!!~

@Legitgoons Legitgoons merged commit a9c5559 into main May 6, 2024
2 checks passed
@Legitgoons Legitgoons deleted the feature/PW-261-user-msw branch May 6, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BangDori BangDori BangDori approved these changes

Assignees

@Legitgoons Legitgoons

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Legitgoons @BangDori