Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

๐Ÿ› ๏ธ fonts ํด๋ž˜์Šค ์ค‘๋ณต ์ฒ˜๋ฆฌ ๋ฌธ์ œ ๊ฐœ์„  #31

Merged
merged 6 commits into from
May 6, 2024
Merged

๐Ÿ› ๏ธ fonts ํด๋ž˜์Šค ์ค‘๋ณต ์ฒ˜๋ฆฌ ๋ฌธ์ œ ๊ฐœ์„  #31

merged 6 commits into from
May 6, 2024

Conversation

BangDori
Copy link
Collaborator

@BangDori BangDori commented May 5, 2024 •
edited by Legitgoons
Loading

์ž‘์—… ์ด์œ 

#18, ํฐํŠธ ํด๋ž˜์Šค๊ฐ€ ์ค‘๋ณต์œผ๋กœ ์ฒ˜๋ฆฌ๋˜๋Š” ๋ฌธ์ œ ํ•ด๊ฒฐ


์ž‘์—… ์‚ฌํ•ญ

  • ๊ธฐ์กด์— ํฐํŠธ ํด๋ž˜์Šค๊ฐ€ ์ค‘๋ณต์œผ๋กœ ์ ์šฉ๋˜๋Š” ๋ฌธ์ œ๋ฅผ ํ•ด๊ฒฐํ•˜์˜€์Šต๋‹ˆ๋‹ค.
  • ๋ชจ๋“ˆ์‹ ์Šคํƒ€์ผ ์‹œํŠธ์— ๋Œ€ํ•ด ์–ธ๋”๋ฐ”๋ฅผ ์ถ”๊ฐ€ํ•˜์˜€์Šต๋‹ˆ๋‹ค.
  • font์™€ reset ์Šคํƒ€์ผ ์‹œํŠธ์˜ ๊ฒฝ์šฐ ์ „์—ญ ์Šคํƒ€์ผ ์„ค์ •์ด๋ผ๊ณ  ์ƒ๊ฐํ•˜์—ฌ, app ํด๋”์— ์œ„์น˜ํ•˜์˜€์Šต๋‹ˆ๋‹ค.

๋ฆฌ๋ทฐ์–ด๊ฐ€ ์ค‘์ ์ ์œผ๋กœ ํ™•์ธํ•ด์•ผ ํ•˜๋Š” ๋ถ€๋ถ„

  • scss๋ฅผ ์ „์—ญ์œผ๋กœ ์‚ฌ์šฉํ•˜๋Š” ๋ฐฉ๋ฒ•์— ๋Œ€ํ•ด ์ธ์ง€ํ•˜์…จ๋‚˜์š”?

๋ฐœ๊ฒฌํ•œ ์ด์Šˆ

  • ActiveButton ๊ณผ BasicButton ์ปดํฌ๋„ŒํŠธ์—์„œ fonts ํด๋ž˜์Šค๋ฅผ extends ํ•ด์™€์„œ ์‚ฌ์šฉํ•˜๊ณ  ์žˆ์—ˆ๋Š”๋ฐ, ์ด๋ฅผ ์ „์—ญ์œผ๋กœ ์„ค์ •ํ•ด์ฃผ๋ฉด์„œ extends ์‚ฌ์šฉ์ด ๋ถˆ๊ฐ€๋Šฅํ•ด์ง€๊ฒŒ ๋˜์—ˆ์Šต๋‹ˆ๋‹ค. ํ•ด๋‹น ๋ฌธ์ œ๋Š” ์ด์Šˆ๋กœ ์ถ”๊ฐ€ํ•ด๋‘๊ฒ ์Šต๋‹ˆ๋‹ค.

@BangDori BangDori self-assigned this May 5, 2024
@aws-amplify-ap-northeast-2 AWS Amplify (ap-northeast-2)
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-31.d37mn03xh3qyyz.amplifyapp.com

@BangDori BangDori mentioned this pull request May 5, 2024
Closed
1 task
Legitgoons
Legitgoons approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@Legitgoons Legitgoons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ˆ˜๊ณ ํ•˜์…จ์Šต๋‹ˆ๋‹ค. ๋ณ‘ํ•ฉํ•˜์…”๋„ ์ข‹์Šต๋‹ˆ๋‹ค.
image

@BangDori BangDori merged commit 9eb43a3 into main May 6, 2024
2 checks passed
@BangDori BangDori deleted the fix/issue-18-fonts branch May 6, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Legitgoons Legitgoons Legitgoons approved these changes

Assignees

@BangDori BangDori

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BangDori @Legitgoons