Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ› ๏ธ ํ”ผ๋“œ ๋ฉ”์ธ ํŽ˜์ด์ง€ ํ”ผ๋“œ๋ฐฑ ๋ฐ˜์˜ #38

Merged
merged 7 commits into from
May 7, 2024

Conversation

BangDori
Copy link
Collaborator

@BangDori BangDori commented May 7, 2024

์ž‘์—… ์ด์œ 

  • ํ”ผ๋“œ ๋ฉ”์ธ ํŽ˜์ด์ง€ ํ”ผ๋“œ๋ฐฑ ๋ฐ˜์˜

์ž‘์—… ์‚ฌํ•ญ

1๏ธโƒฃ ํ”ผ๋“œ ๋ฉ”์ธ ํŽ˜์ด์ง€ ์Šคํฌ๋กค

ํ”ผ๋“œ ๋ฉ”์ธ ํŽ˜์ด์ง€์—์„œ ์Šคํฌ๋กค ๋˜๋Š” ๊ฒƒ์€ ์›น ์ƒ์—์„œ ๊ธฐ๋ณธ์ ์œผ๋กœ ์ œ๊ณตํ•ด์ฃผ๋Š” ๊ธฐ๋Šฅ์œผ๋กœ, Mobile๋กœ ํ™•์ธํ–ˆ์„ ๋•Œ์—๋Š” ์Šคํฌ๋กค์ด ํ‘œ์‹œ๋˜์ง€ ์•Š๋Š” ๊ฒƒ์œผ๋กœ ํ™•์ธ๋˜์—ˆ์Šต๋‹ˆ๋‹ค!

๊ทธ๋ž˜์„œ ์šฐ์„ , ๋”ฐ๋กœ ์ฒ˜๋ฆฌํ•ด๋‘์ง€ ์•Š์•˜๋Š”๋ฐ ๋งŒ์•ฝ iOS์—์„œ WebView๋ฅผ loadํ–ˆ์„ ๋•Œ ์Šคํฌ๋กค์ด ํ‘œ์‹œ๋œ๋‹ค๋ฉด ๋”ฐ๋กœ ์ฒ˜๋ฆฌํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค.

2๏ธโƒฃ ํ”ผ๋“œ ๋ฉ”์ธ ํŽ˜์ด์ง€์—์„œ ์Šคํฌ๋กค ์‹œ 2 ํŽ˜์ด์ง€๋ถ€ํ„ฐ ์Šค์ผˆ๋ ˆํ†ค UI๊ฐ€ ํ‘œ์‹œ๋˜์ง€ ์•Š๋Š” ๋ฌธ์ œ

์ดˆ๊ธฐ ๋กœ๋”ฉ ์‹œ ์Šค์ผˆ๋ ˆํ†ค UI๋ฅผ 10๊ฐœ ๋ณด์—ฌ์ฃผ๊ณ , ์ดํ›„์— 2ํŽ˜์ด์ง€๋ถ€ํ„ฐ๋Š” ์Šค์ผˆ๋ ˆํ†ค UI๋ฅผ 3๊ฐœ์”ฉ ๋ณด์—ฌ์ฃผ๋„๋ก ์„ค์ •ํ•˜์˜€์Šต๋‹ˆ๋‹ค.

3๏ธโƒฃ ํ”ผ๋“œ ๋ฉ”์ธ ํŽ˜์ด์ง€ ์‹œ๋‚˜๋ฆฌ์˜ค ์ถ”๊ฐ€

์‹ค์ œ ํ™˜๊ฒฝ๊ณผ ๋™์ผํ•œ ํ™˜๊ฒฝ์„ ๊ตฌ์„ฑํ•˜๊ธฐ ์œ„ํ•ด Feed ๋ฌดํ•œ ์Šคํฌ๋กค ์‹œ API ์‘๋‹ต ์‹œ๊ฐ„์„ ์ž„์˜๋กœ 2 ~ 4์ดˆ๋กœ ์„ค์ •ํ•˜๊ณ , ํด๋ผ์ด์–ธํŠธ์ธก์—์„œ๋Š” API Timeout์„ 3์ดˆ๋กœ ์„ค์ •ํ•˜์˜€์Šต๋‹ˆ๋‹ค.

๋„คํŠธ์›Œํฌ ์—๋Ÿฌ ํ† ์ŠคํŠธ ๋ฉ”์‹œ์ง€์˜ ๊ฒฝ์šฐ์—๋Š” API ์—๋Ÿฌ๊ฐ€ ๋ฐœ์ƒํ•  ๊ฒฝ์šฐ ํ‘œ์‹œ๋˜๊ณ , ๋‹ค์‹œ API ์š”์ฒญ์ด ์ •์ƒ์ ์œผ๋กœ ์ฒ˜๋ฆฌ๋˜๋ฉด ์‚ฌ๋ผ์ง€๊ฒŒ ํ•˜์˜€์Šต๋‹ˆ๋‹ค.


๋ฆฌ๋ทฐ์–ด๊ฐ€ ์ค‘์ ์ ์œผ๋กœ ํ™•์ธํ•ด์•ผ ํ•˜๋Š” ๋ถ€๋ถ„

  • ์Šค์ผˆ๋ ˆํ†ค UI๊ฐ€ ์ดˆ๊ธฐ ๋กœ๋”ฉ๊ณผ ๋‹ค์Œ ํŽ˜์ด์ง€๋ฅผ ์š”์ฒญํ•  ๋•Œ๋„ ์ •์ƒ์ ์œผ๋กœ ํ‘œ์‹œ๋˜๊ณ  ์žˆ๋‚˜์š”?
  • ๋„คํŠธ์›Œํฌ ์—๋Ÿฌ ํ† ์ŠคํŠธ ๋ฉ”์‹œ์ง€๊ฐ€ ์ •์ƒ์ ์œผ๋กœ ํ‘œ์‹œ๋˜๊ณ , ์‚ฌ๋ผ์ง€๋‚˜์š”?
  • ์ด ์™ธ์— ํ˜น์‹œ ์ œ๊ฐ€ ํ™•์ธํ•˜์ง€ ๋ชปํ•œ ๋ถ€๋ถ„์ด ์žˆ์„๊นŒ์š”?

๋ฐœ๊ฒฌํ•œ ์ด์Šˆ

BangDori added 5 commits May 7, 2024 14:34
- ์‹ค์ œ ํ™˜๊ฒฝ ํ…Œ์ŠคํŠธ๋ฅผ ์œ„ํ•œ delay 2~4์ดˆ ์„ค์ •
- API ์—๋Ÿฌ ๋ฐœ์ƒ ์‹œ, ๋„คํŠธ์›Œํฌ ํ† ์ŠคํŠธ ๋ฉ”์‹œ์ง€ ํ‘œ์‹œ
- API ์š”์ฒญ ์„ฑ๊ณต ์‹œ, ๋„คํŠธ์›Œํฌ ํ† ์ŠคํŠธ ๋ฉ”์‹œ์ง€ ์ œ๊ฑฐ
@BangDori BangDori self-assigned this May 7, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-38.d37mn03xh3qyyz.amplifyapp.com

@BangDori BangDori removed the request for review from psychology50 May 7, 2024 07:44
Copy link
Member

@Legitgoons Legitgoons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amplify ๋ฐฐํฌ ํŽ˜์ด์ง€์—์„œ ํ† ์ŠคํŠธ ๋ฉ”์‹œ์ง€๊ฐ€ ์ •์ƒ์ ์œผ๋กœ ํ‘œ์‹œ๋˜์ง€ ์•Š๊ณ  ์žˆ์Šต๋‹ˆ๋‹ค. ์ˆ˜์ •์ด ํ•„์š”ํ•ด๋ณด์—ฌ request changes๋กœ ์„ค์ •ํ•˜๊ฒ ์Šต๋‹ˆ๋‹น

src/shared/ui/network-toast-error/NetworkToastError.tsx Outdated Show resolved Hide resolved
src/shared/axios/config/instance.ts Show resolved Hide resolved
Copy link
Member

@Legitgoons Legitgoons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ˆ˜์ •๋œ ๋ถ€๋ถ„ ํ™•์ธํ–ˆ์Šต๋‹ˆ๋‹ค. ๋ณ‘ํ•ฉํ•˜์…”๋„ ์ข‹์Šต๋‹ˆ๋‹ค!

@BangDori BangDori merged commit c785987 into main May 7, 2024
2 checks passed
@BangDori BangDori deleted the fix/PW-300-feed branch May 7, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants