-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚙️ MSW Follow, Search, User Test 코드 #51
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
같은 도메인에 따라 관리하기 위해서 user api 항목을 follow, profile, search로 분리하였습니다. 또한 follow handler의 코드가 일부 수정되었습니다.
…/pennyway-client-webview into feature/PW-296-user-test
UI 수정으로 인해 삭제했습니다.
This pull request is automatically being deployed by Amplify Hosting (learn more). |
BangDori
approved these changes
May 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
테스트 코드를 간결하고 가독성 높게 잘 작성하신 것 같아서 편하게 코드를 읽을 수 있었던 것 같습니다!!
테스트 코드 작성하시느라 고생하셨어요 ㅎㅎ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 이유
Follow, Search, User API에 대한 Test 코드 등록
작업 사항
1️⃣ Follow
2️⃣ Search
3️⃣ User
리뷰어가 중점적으로 확인해야 하는 부분
발견한 이슈