-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ 피드 신고 UI #57
Merged
Merged
✨ 피드 신고 UI #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 기존에 checkon, checkoff 에서 모양을 추가하였습니다. - checkbox-circle_state, checkbox-square_state
This pull request is automatically being deployed by Amplify Hosting (learn more). |
Legitgoons
approved these changes
May 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고 많으셨습니다. hooks도 잘 분리하셨고, 카테고리를 따로 변수로 분리해서 처리하는 점도 좋았습니다. 병합하셔도 좋습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 이유
작업 사항
1️⃣ 피드 신고 UI
useReportCategories
hook 관리useInput
hook 관리useToggle
hook 관리하나의 컴포넌트에서 하나의 관심사를 가질 수 있도록 컴포넌트들을 제작하였습니다.
2️⃣ useHooks 공용 훅 구현
리뷰어가 중점적으로 확인해야 하는 부분
📌 개인적으로 피드 신고 양식 폼에 부족한 점이 많다고 생각합니다! 개선 사항 혹은 의문점이 드시는 부분에 대해 적극적으로 질문 부탁드립니다!
발생한 이슈에 대해 인지하셨나요?
발견한 이슈