Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ› ๏ธ ๊ณตํ†ต Button, Modal ์ปดํฌ๋„ŒํŠธ ์ˆ˜์ • #63

Merged
merged 23 commits into from
May 16, 2024

Conversation

Legitgoons
Copy link
Member

@Legitgoons Legitgoons commented May 15, 2024

์ž‘์—… ์ด์œ 

#61
๊ธฐ์กด ๊ณตํ†ต Button, Modal ์ปดํฌ๋„ŒํŠธ์˜ ๋ฌธ์ œ์  ํ•ด๊ฒฐ

์ž‘์—… ์‚ฌํ•ญ

1๏ธโƒฃ ActiveButton / BasicButton ์ œ๊ฑฐ

  • ํ•ด๋‹น ์ปดํฌ๋„ŒํŠธ๋“ค์˜ ์‚ฌ์šฉ์„ฑ์ด ๋ถ€์กฑํ•˜์—ฌ ์ œ๊ฑฐํ•˜์˜€์Šต๋‹ˆ๋‹ค.

2๏ธโƒฃ ConfirmModalButton ๋ฐ FollowButton ์ถ”๊ฐ€

  • ๊ธฐ์กด์˜ Button ์ปดํฌ๋„ŒํŠธ ๋Œ€์‹ , ๊ณตํ†ต์œผ๋กœ ์‚ฌ์šฉ๋˜๋Š” ํ•ด๋‹น ์ปดํฌ๋„ŒํŠธ๋“ค์„ ๊ตฌํ˜„ํ•˜์˜€์Šต๋‹ˆ๋‹ค.
  • ๋‘ ๋ฒ„ํŠผ ์ค‘, shared ์™ธ๋ถ€์—์„œ๋„ ์‚ฌ์šฉ๋˜๋Š” FollowButton๋งŒ index.ts์— ์ถ”๊ฐ€ํ•˜์˜€์Šต๋‹ˆ๋‹ค.

3๏ธโƒฃ ConfirmModal ์Šคํƒ€์ผ์— ๋ถ„๊ธฐ๋ฌธ ์ •๋ฆฌ

  • isReport ๋ถ„๊ธฐ๋ฌธ์„ ์‚ญ์ œํ•˜์˜€์Šต๋‹ˆ๋‹ค.

4๏ธโƒฃ ConfirmReportModal ๋‚ด๋ถ€ ๋ฒ„ํŠผ ReportModalButton ๊ตฌํ˜„

  • ์•„๋ž˜์˜ ์†์„ฑ๋“ค์„ props๋กœ ๊ฐ€์ง€๋Š” ReportModalButton ์ปดํฌ๋„ŒํŠธ๋ฅผ ๊ตฌํ˜„ํ•˜์˜€์Šต๋‹ˆ๋‹ค.
  onClick: React.MouseEventHandler<HTMLButtonElement>;
  children: React.ReactNode;
  styleClass: ReportModalButtonStyle;
  type?: 'button' | 'submit' | 'reset'; // ๊ธฐ๋ณธ ๊ฐ’ 'submit'
  isDisabled?: boolean; // ๊ธฐ๋ณธ ๊ฐ’ 'false'

๋ฆฌ๋ทฐ์–ด๊ฐ€ ์ค‘์ ์ ์œผ๋กœ ํ™•์ธํ•ด์•ผ ํ•˜๋Š” ๋ถ€๋ถ„

  • ReportModalButton์˜ ๊ตฌํ˜„์ด ์ ์ ˆํ•œ์ง€
  • ์ถ”๊ฐ€์ ์œผ๋กœ ์ˆ˜์ •ํ•ด์•ผ ํ•  ๋ถ€๋ถ„์ด ์žˆ๋Š”์ง€
  • ์ˆ˜์ •๋œ ์ปดํฌ๋„ŒํŠธ๋“ค์˜ ์‚ฌ์šฉ์„ฑ๊ณผ ๊ฐ€๋…์„ฑ์ด ํ–ฅ์ƒ๋˜์—ˆ๋Š”์ง€

๋ฐœ๊ฒฌํ•œ ์ด์Šˆ

X

@Legitgoons Legitgoons self-assigned this May 15, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-63.d37mn03xh3qyyz.amplifyapp.com

Copy link
Collaborator

@BangDori BangDori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FSD ์•„ํ‚คํ…์ฒ˜์˜ ๊ด€์ ์— ๋Œ€ํ•ด ์ดํ•ดํ•˜๋ ค๊ณ  ๋…ธ๋ ฅํ•˜๋ฉฐ ํ”„๋กœ์ ํŠธ๋ฅผ ์ง„ํ–‰ํ•˜๋Š” ๋ชจ์Šต์ด ์ธ์ƒ ๊นŠ๋„ค์š” ใ…Žใ…Ž

์ด์Šˆ์— ๋“ฑ๋ก๋˜์–ด์žˆ์—ˆ๋˜ task๋Š” ๋ชจ๋‘ ์™„๋ฃŒ ์ฒ˜๋ฆฌํ•˜์˜€์Šต๋‹ˆ๋‹ค!

src/shared/styles/_colors.scss Outdated Show resolved Hide resolved
src/features/feed-reports/ui/ReportModalButton.tsx Outdated Show resolved Hide resolved
src/shared/ui/button/ConfirmModalButton.scss Outdated Show resolved Hide resolved
src/shared/ui/button/ConfirmModalButton.tsx Outdated Show resolved Hide resolved
src/shared/ui/index.ts Show resolved Hide resolved
Copy link
Collaborator

@BangDori BangDori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:disabled ์„ ํƒ์ž๋ฅผ ํ™œ์šฉํ•˜๋Š” ํŽธ์ด ๋” ๋‚ซ๋‹ค๊ณ  ์ƒ๊ฐํ•˜๋Š”๋ฐ ์ด์— ๋Œ€ํ•ด ์˜๊ฒฌ ๊ณต์œ  ๋ถ€ํƒ๋“œ๋ฆด๊ฒŒ์š”!

src/features/feed-reports/ui/ConfirmReportModal.tsx Outdated Show resolved Hide resolved
Copy link
Collaborator

@BangDori BangDori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค!

@Legitgoons Legitgoons merged commit 845d922 into main May 16, 2024
2 checks passed
@Legitgoons Legitgoons deleted the fix/shared-ui branch May 16, 2024 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants