-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ 피드 숨기기 API 연동 #69
Merged
Merged
✨ 피드 숨기기 API 연동 #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 성능 개선 O(N) -> O(1)
This pull request is automatically being deployed by Amplify Hosting (learn more). |
Legitgoons
approved these changes
May 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다. 간단한 질문이 있는데 답변 후 병합해주시면 됩니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 이유
작업 사항
1️⃣ 피드 숨기기 API MSW 등록
2️⃣ 피드 숨기기 API
리뷰어가 중점적으로 확인해야 하는 부분
발견한 이슈
zustand를 위와 같이 선언해두고, 그냥 addHiddenFeed와 cancelHiddenFeed 만을 호출하여서 리렌더링이 발생하지 않았습니다! 단순히 리렌더링을 필요로하는 컴포넌트에서 useHiddenFeedStore 훅스를 가져와서 사용하여 해결하였습니다.