Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ 피드 메인 페이지 UI 업데이트 #80

Merged
merged 6 commits into from
May 25, 2024
Merged

Conversation

BangDori
Copy link
Collaborator

@BangDori BangDori commented May 25, 2024

작업 이유

  • 피드 메인 페이지 UI 업데이트 반영

작업 사항

1️⃣ 캐러셀 UI 업데이트 반영

  1. 이미지 비율 조정
    • 모킹 데이터 이미지 비율: 320x400 -> 320x320
    • aspect-ratio: 1/1;
  2. 캐러셀 컨트롤 박스 간격 조정
    • 하단 기준 16px -> 12px

2️⃣ 신고하기 UI 업데이트 반영

  1. 신고하기 글자 수 위치 이동
    • 글자 수 표기 내부 -> 외부
  2. 숨기기 버튼 간격 수정
    • margin: 12px 0 20px -> margin-bottom: 22px

리뷰어가 중점적으로 확인해야 하는 부분

  • 피그마와 동일하게 업데이트 되었나요?

발견한 이슈

  • 없음

@BangDori BangDori requested a review from Legitgoons May 25, 2024 09:48
@BangDori BangDori self-assigned this May 25, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-80.d37mn03xh3qyyz.amplifyapp.com

Copy link
Member

@Legitgoons Legitgoons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다. 댓글 확인 부탁드립니다!

src/features/feed-reports/ui/FeedReportsForm.scss Outdated Show resolved Hide resolved
Copy link
Member

@Legitgoons Legitgoons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고많으셨습니다. 병합하셔도 좋습니다!

@BangDori BangDori merged commit 3ef81c7 into main May 25, 2024
2 checks passed
@BangDori BangDori deleted the feature/feed-ui-update branch May 25, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants