Skip to content

Qodana

Qodana #138

GitHub Actions / Qodana for .NET completed Sep 13, 2024 in 0s

739 new problems found by Qodana for .NET

Qodana for .NET

739 new problems were found

Inspection name Severity Problems
Auto-property accessor is never used (non-private accessibility) 🔶 Warning 67
Possible 'System.NullReferenceException' 🔶 Warning 57
Possible 'null' assignment to non-nullable entity 🔶 Warning 38
Invalid XML documentation comment 🔶 Warning 33
Redundant cast 🔶 Warning 33
Assignment is not used 🔶 Warning 31
Redundant 'partial' modifier on type declaration 🔶 Warning 26
Virtual member call in constructor 🔶 Warning 26
Conditional access qualifier expression is not null according to nullable reference types' annotations 🔶 Warning 24
Conditional access qualifier expression is known to be null or not null 🔶 Warning 24
Redundant catch clause 🔶 Warning 21
Redundant class or interface specification in base types list 🔶 Warning 17
Return value of [MustUseReturnValue] annotated method is not used 🔶 Warning 16
Unused local variable 🔶 Warning 16
Redundant using directive 🔶 Warning 14
Property value is equal to style-provided 🔶 Warning 14
Incorrect indent (around child statement) 🔶 Warning 12
Expression is always 'true' or always 'false' 🔶 Warning 12
Expression is always 'true' or 'false' according to nullable reference types' annotations 🔶 Warning 12
Redundant control flow jump statement 🔶 Warning 12
Missing grid column/row setter for non-first child 🔶 Warning 11
Access to modified captured variable 🔶 Warning 10
Redundant base constructor call 🔶 Warning 10
Non-readonly type member referenced in 'GetHashCode()' 🔶 Warning 9
Unsafe context declaration is redundant 🔶 Warning 9
Grid element column/row index is out of grid definition range 🔶 Warning 9
Underlying type of enum is 'int' 🔶 Warning 8
Possible multiple enumeration 🔶 Warning 8
'??' condition is known to be null or not null 🔶 Warning 7
Possible 'System.InvalidOperationException' 🔶 Warning 7
Variable can be declared as non-nullable 🔶 Warning 7
Member initialized value ignored 🔶 Warning 6
Non-accessed local variable 🔶 Warning 6
Parameter hides member 🔶 Warning 6
Redundant lambda expression parameter type specification 🔶 Warning 6
Remove redundant attached property setter 🔶 Warning 6
Possible overflow in unchecked context 🔶 Warning 5
Non-accessed field (private accessibility) 🔶 Warning 5
Redundant 'base.' qualifier 🔶 Warning 5
Auto-property accessor is never used (private accessibility) 🔶 Warning 5
Variable in local function hides variable from outer scope 🔶 Warning 5
Use of obsolete symbol 🔶 Warning 4
Collection content is never queried (non-private accessibility) 🔶 Warning 4
Empty general catch clause 🔶 Warning 4
Heuristically unreachable code 🔶 Warning 4
Cannot resolve symbol in text argument 🔶 Warning 4
Redundant 'IEnumerable.Cast<T>' or 'IEnumerable.OfType<T>' call 🔶 Warning 4
Unused nullable directive 🔶 Warning 4
Collection content is never queried (private accessibility) 🔶 Warning 3
Use null check pattern instead of a type check succeeding on any not-null value 🔶 Warning 3
Local variable hides member 🔶 Warning 3
Mismatch of optional parameter value in overridden method 🔶 Warning 3
Actual shift count equals zero 🔶 Warning 3
String.IndexOf is culture-specific (string.IndexOf(string) is culture-specific) 🔶 Warning 3
'?:' expression has identical true and false branches 🔶 Warning 2
Empty constructor 🔶 Warning 2
Possible unassigned object created by 'new' expression 🔶 Warning 2
Possible loss of fraction 🔶 Warning 2
Possible unintended reference comparison 🔶 Warning 2
Explicit delegate creation expression is redundant 🔶 Warning 2
Do not use object initializer for 'using' variable 🔶 Warning 2
Path error 🔶 Warning 2
Assignment in conditional expression 🔶 Warning 1
Bitwise operation on enum is not marked by [Flags] attribute 🔶 Warning 1
Non-nullable member is uninitialized. 🔶 Warning 1
Co-variant array conversion 🔶 Warning 1
Non-accessed field 🔶 Warning 1
Return value must be disposed but the method or function is not annotated with [MustDisposeResource] 🔶 Warning 1
Parameter output value is always discarded (private accessibility) 🔶 Warning 1
Redundant 'partial' modifier on method declaration 🔶 Warning 1
The source expression always matches the provided pattern 🔶 Warning 1
Redundant explicit type in array creation 🔶 Warning 1
Redundant nullable directive 🔶 Warning 1
Redundant nullable warning suppression expression 🔶 Warning 1
Redundant 'object.ToString()' call 🔶 Warning 1
Redundant type arguments of method 🔶 Warning 1
Redundant global using directive 🔶 Warning 1
Return value of pure method is not used 🔶 Warning 1
String.LastIndexOf is culture-specific (string.LastIndexOf(string) is culture-specific) 🔶 Warning 1
Method return value is never used (private accessibility) 🔶 Warning 1
Type is never used (private accessibility) 🔶 Warning 1
Single-cell grid column/row span is redundant 🔶 Warning 1
Redundant namespace alias 🔶 Warning 1
Redundant resource 🔶 Warning 1

☁️ View the detailed Qodana report

Detected 103 dependencies

Third-party software list

This page lists the third-party software dependencies used in CollapseLauncher

Dependency Version Licenses
Clowd.Squirrel 2.11.1 MIT
CommunityToolkit.Common 8.3.0 MIT
CommunityToolkit.Mvvm 8.3.0 MIT
CommunityToolkit.WinUI.Animations 8.1.240821 MIT
CommunityToolkit.WinUI.Behaviors 8.1.240821 MIT
CommunityToolkit.WinUI.Controls.ImageCropper 8.1.240821 MIT
CommunityToolkit.WinUI.Controls.Primitives 8.1.240821 MIT
CommunityToolkit.WinUI.Controls.SettingsControls 8.1.240821 MIT
CommunityToolkit.WinUI.Controls.Sizers 8.1.240821 MIT
CommunityToolkit.WinUI.Converters 8.1.240821 MIT
CommunityToolkit.WinUI.Extensions 8.1.240821 MIT
CommunityToolkit.WinUI.Helpers 8.1.240821 MIT
CommunityToolkit.WinUI.Media 8.1.240821 MIT
CommunityToolkit.WinUI.Triggers 8.1.240821 MIT
GitInfo 3.3.5 MIT
Google.Protobuf.Tools 3.28.0 PROTOBUF
Google.Protobuf 3.28.0 BSD-3-Clause
Google.Protobuf 3.28.1 BSD-3-Clause
H.GeneratedIcons.System.Drawing 2.1.3 MIT
H.NotifyIcon.WinUI 2.1.3 MIT
H.NotifyIcon 2.1.3 MIT
Hi3Helper.ZstdNet 1.6.2 BSD-3-Clause
HtmlAgilityPack 1.11.65 MIT
Markdig.Signed 0.37.0 BSD-2-Clause
Microsoft.CSharp 4.7.0 MIT
Microsoft.Graphics.Win2D 1.2.1-experimental2 MS-ASP-NET-WEB-OPTIMIZATION
Microsoft.NET.ILLink.Tasks 8.0.5 MIT
Microsoft.NETCore.Platforms 8.0.0-preview.7.23375.6 MIT
Microsoft.NETCore.Targets 6.0.0-preview.4.21253.7 MIT
Microsoft.Web.WebView2 1.0.2651.64 BSD-3-Clause
BSD-MYLEX
Microsoft.Win32.Registry 5.0.0 MIT
Microsoft.Win32.SystemEvents 8.0.0 MIT
Microsoft.Windows.CsWinRT 2.1.1 MIT
Microsoft.Windows.SDK.BuildTools 10.0.22621.756 PROPRIETARY-LICENSE
Microsoft.Windows.SDK.BuildTools 10.0.26100.1 PROPRIETARY-LICENSE
Microsoft.WindowsAppSDK 1.6.240829007 MIT
MS-DXSDK-D3DX-9.29.952.3
Microsoft.Xaml.Behaviors.WinUI.Managed 2.0.9 MIT
PhotoSauce.MagicScaler 0.14.2 MIT
PhotoSauce.NativeCodecs.Libwebp 1.3.2-preview3 MIT
Roman-Numerals 2.0.1 MIT
SharpCompress 0.38.0 MIT
SharpHDiffPatch.Core 2.2.7 MIT
System.Collections.Concurrent 4.3.0 MIT
System.Collections 4.3.0 MIT
System.Diagnostics.Debug 4.3.0 MIT
System.Diagnostics.DiagnosticSource 4.3.0 MIT
System.Diagnostics.EventLog 8.0.0 MIT
System.Diagnostics.Tracing 4.3.0 MIT
System.Drawing.Common 8.0.8 MIT
System.Globalization.Calendars 4.3.0 MIT
System.Globalization.Extensions 4.3.0 MIT
System.Globalization 4.3.0 MIT
System.IO.FileSystem.Primitives 4.3.0 MIT
System.IO.FileSystem 4.3.0 MIT
System.IO.Hashing 8.0.0 MIT
System.IO 4.3.0 MIT
System.Linq 4.3.0 MIT
System.Net.Http 4.3.4 MIT
System.Net.Primitives 4.3.0 MIT
System.Reflection.Primitives 4.3.0 MIT
System.Reflection 4.3.0 MIT
System.Resources.ResourceManager 4.3.0 MIT
System.Runtime.Extensions 4.3.0 MIT
System.Runtime.Handles 4.3.0 MIT
System.Runtime.InteropServices 4.3.0 MIT
System.Runtime.Numerics 4.3.0 MIT
System.Runtime 4.3.1 MIT
System.Security.AccessControl 6.0.1 MIT
System.Security.Cryptography.Algorithms 4.3.0 MIT
System.Security.Cryptography.Cng 4.3.0 MIT
System.Security.Cryptography.Csp 4.3.0 MIT
System.Security.Cryptography.Encoding 4.3.0 MIT
System.Security.Cryptography.OpenSsl 4.3.0 MIT
System.Security.Cryptography.Primitives 4.3.0 MIT
System.Security.Cryptography.ProtectedData 8.0.0 MIT
System.Security.Cryptography.X509Certificates 4.3.0 MIT
System.Security.Principal.Windows 5.0.0 MIT
System.Text.Encoding.CodePages 8.0.0 MIT
System.Text.Encoding 4.3.0 MIT
System.Text.Encodings.Web 8.0.0 MIT
System.Text.Json 8.0.4 MIT
System.Text.RegularExpressions 4.3.1 MIT
System.Threading.Tasks.Extensions 4.5.4 MIT
System.Threading.Tasks 4.3.0 MIT
System.Threading 4.3.0 MIT
TaskScheduler 2.11.0 MIT
ThisAssembly.Constants 1.4.1 MIT
ZstdSharp.Port 0.8.1 MIT
runtime.debian.8-x64.runtime.native.System.Security.Cryptography.OpenSsl 4.3.2 MIT
runtime.fedora.23-x64.runtime.native.System.Security.Cryptography.OpenSsl 4.3.2 MIT
runtime.fedora.24-x64.runtime.native.System.Security.Cryptography.OpenSsl 4.3.2 MIT
runtime.native.System.Net.Http 4.3.0 MIT
runtime.native.System.Security.Cryptography.Apple 4.3.0 MIT
runtime.native.System.Security.Cryptography.OpenSsl 4.3.2 MIT
runtime.native.System 4.3.0 MIT
runtime.opensuse.13.2-x64.runtime.native.System.Security.Cryptography.OpenSsl 4.3.2 MIT
runtime.opensuse.42.1-x64.runtime.native.System.Security.Cryptography.OpenSsl 4.3.2 MIT
runtime.osx.10.10-x64.runtime.native.System.Security.Cryptography.Apple 4.3.0 MIT
runtime.osx.10.10-x64.runtime.native.System.Security.Cryptography.OpenSsl 4.3.2 MIT
runtime.rhel.7-x64.runtime.native.System.Security.Cryptography.OpenSsl 4.3.2 MIT
runtime.ubuntu.14.04-x64.runtime.native.System.Security.Cryptography.OpenSsl 4.3.2 MIT
runtime.ubuntu.16.04-x64.runtime.native.System.Security.Cryptography.OpenSsl 4.3.2 MIT
runtime.ubuntu.16.10-x64.runtime.native.System.Security.Cryptography.OpenSsl 4.3.2 MIT
Contact Qodana team

Contact us at [email protected]

Details

This result was published with Qodana GitHub Action

Annotations

Check warning on line 487 in CollapseLauncher/XAMLs/MainApp/Pages/Dialogs/SimpleDialogs.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Access to modified captured variable

Captured variable is modified in the outer scope

Check warning on line 486 in CollapseLauncher/XAMLs/MainApp/Pages/Dialogs/SimpleDialogs.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Access to modified captured variable

Captured variable is modified in the outer scope

Check warning on line 497 in CollapseLauncher/XAMLs/MainApp/Pages/Dialogs/SimpleDialogs.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Access to modified captured variable

Captured variable is modified in the outer scope

Check warning on line 560 in Hi3Helper.Sophon/SophonAsset.Download.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Access to modified captured variable

Captured variable is modified in the outer scope

Check warning on line 485 in CollapseLauncher/XAMLs/MainApp/Pages/Dialogs/SimpleDialogs.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Access to modified captured variable

Captured variable is modified in the outer scope

Check warning on line 434 in Hi3Helper.Sophon/SophonAsset.Diff.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Access to modified captured variable

Captured variable is modified in the outer scope

Check warning on line 424 in Hi3Helper.Sophon/SophonAsset.Diff.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Access to modified captured variable

Captured variable is modified in the outer scope

Check warning on line 550 in Hi3Helper.Sophon/SophonAsset.Download.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Access to modified captured variable

Captured variable is modified in the outer scope

Check warning on line 566 in Hi3Helper.Sophon/SophonAsset.Download.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Access to modified captured variable

Captured variable is modified in the outer scope

Check warning on line 440 in Hi3Helper.Sophon/SophonAsset.Diff.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Access to modified captured variable

Captured variable is modified in the outer scope

Check warning on line 132 in CollapseLauncher/Classes/InstallManagement/GameConversionManagement.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Possible 'null' assignment to non-nullable entity

Possible 'null' assignment to non-nullable entity

Check warning on line 122 in CollapseLauncher/Classes/ShortcutCreator/SteamShortcut.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Possible 'null' assignment to non-nullable entity

Possible 'null' assignment to non-nullable entity

Check warning on line 259 in CollapseLauncher/XAMLs/MainApp/Pages/Dialogs/InstallationConvert.xaml.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Possible 'null' assignment to non-nullable entity

Possible 'null' assignment to non-nullable entity

Check warning on line 303 in CollapseLauncher/Classes/InstallManagement/GameConversionManagement.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Possible 'null' assignment to non-nullable entity

Possible 'null' assignment to non-nullable entity

Check warning on line 42 in SevenZipExtractor/SevenZipExtractor/SevenZipHandle.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Possible 'null' assignment to non-nullable entity

Possible 'null' assignment to non-nullable entity

Check warning on line 79 in CollapseLauncher/Classes/RegistryMonitor/RegistryMonitor.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Possible 'null' assignment to non-nullable entity

Possible 'null' assignment to non-nullable entity

Check warning on line 50 in Hi3Helper.EncTool/Parser/SRMetadata/SRMetadataReader/SRMetadataBase.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Possible 'null' assignment to non-nullable entity

Possible 'null' assignment to non-nullable entity

Check warning on line 388 in CollapseLauncher/XAMLs/MainApp/Pages/Dialogs/SimpleDialogs.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Possible 'null' assignment to non-nullable entity

Possible 'null' assignment to non-nullable entity

Check warning on line 95 in Hi3Helper.EncTool/Parser/Proto/src/StarRailDispatchStatic.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Possible 'null' assignment to non-nullable entity

Possible 'null' assignment to non-nullable entity

Check warning on line 217 in CollapseLauncher/XAMLs/MainApp/Pages/Dialogs/SimpleDialogs.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Possible 'null' assignment to non-nullable entity

Possible 'null' assignment to non-nullable entity

Check warning on line 138 in Hi3Helper.EncTool/Hashes/mhyEncTool.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Possible 'null' assignment to non-nullable entity

Possible 'null' assignment to non-nullable entity

Check warning on line 211 in Hi3Helper.EncTool/Parser/Proto/src/StarRailDispatchStatic.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Possible 'null' assignment to non-nullable entity

Possible 'null' assignment to non-nullable entity

Check warning on line 375 in CollapseLauncher/Classes/RepairManagement/StarRail/Check.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Possible 'null' assignment to non-nullable entity

Possible 'null' assignment to non-nullable entity

Check warning on line 37 in CollapseLauncher/XAMLs/Invoker/Classes/Migrate.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Possible 'null' assignment to non-nullable entity

Possible 'null' assignment to non-nullable entity

Check warning on line 192 in CollapseLauncher/XAMLs/MainApp/Pages/Dialogs/InstallationConvert.xaml.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Possible 'null' assignment to non-nullable entity

Possible 'null' assignment to non-nullable entity