Skip to content

Commit

Permalink
Initialize _kings_data to None in character classes to prevent premat…
Browse files Browse the repository at this point in the history
…ure instantiation
  • Loading branch information
KiloOscarSix committed Jan 21, 2025
1 parent f7c679c commit b3f46cd
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 7 deletions.
7 changes: 6 additions & 1 deletion main_character_ren.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ def __init__(self) -> None:
self.relationships = {}
self.inventory = []

self._kings_data = KingsData()
self._kings_data = None

def __repr__(self) -> str:
return super().__repr__()
Expand All @@ -38,6 +38,11 @@ def name_input(

@property
def kings(self) -> "KingsData":
try:
self._kings_data
except AttributeError:
self._kings_data = KingsData()

if self._kings_data is None:
self._kings_data = KingsData()

Expand Down
6 changes: 3 additions & 3 deletions npcs/aubrey_ren.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ def __init__(self) -> None:
self.pending_simplr_messages = []
self.simplr_messages = []

self._kings_data = KingsData()
self._kings_data = None

@property
def name(self) -> str:
Expand All @@ -48,7 +48,7 @@ def vindictive_characters(self) -> tuple[NonPlayableCharacter, ...]:
@property
def preferred_reputation(self) -> "Reputations":
return Reputations.POPULAR

@property
def kings(self) -> "KingsData":
try:
Expand All @@ -59,4 +59,4 @@ def kings(self) -> "KingsData":
if self._kings_data is None:
self._kings_data = KingsData()

return self._kings_data
return self._kings_data
4 changes: 2 additions & 2 deletions npcs/lindsey_ren.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ def __init__(self) -> None:
self.pending_simplr_messages = []
self.simplr_messages = []

self._kings_data = KingsData()
self._kings_data = None

@property
def name(self) -> str:
Expand Down Expand Up @@ -59,4 +59,4 @@ def kings(self) -> "KingsData":
if self._kings_data is None:
self._kings_data = KingsData()

return self._kings_data
return self._kings_data
4 changes: 3 additions & 1 deletion npcs/sebastian_ren.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ def __init__(self) -> None:
self.pending_simplr_messages = []
self.simplr_messages = []

self._kings_data = None

@property
def name(self) -> str:
return _("Sebastian")
Expand All @@ -40,4 +42,4 @@ def kings(self) -> "KingsData":
if self._kings_data is None:
self._kings_data = KingsData()

return self._kings_data
return self._kings_data

0 comments on commit b3f46cd

Please sign in to comment.