Skip to content
This repository has been archived by the owner on Nov 15, 2022. It is now read-only.

Implement linters #75

Draft
wants to merge 6 commits into
base: develop
Choose a base branch
from
Draft

Implement linters #75

wants to merge 6 commits into from

Conversation

Bigomby
Copy link
Member

@Bigomby Bigomby commented Mar 14, 2020

Description:

This PR adds integration with eslint and prettier. This forces a standard modern JS style for the code along with a lot of linter checks to avoid code smells.

For contributor:

  • Reviewed Files changed in the github PR explorer
  • Attach screenshots of the UI components on the PR description (if applicable)
  • Scope of work approved for big PRs

For reviewer:

  • Manually tested the changes on the UI

@Bigomby Bigomby added the enhancement New feature or request label Mar 14, 2020
@Bigomby Bigomby added this to the Milestone 1 milestone Mar 14, 2020
@Bigomby Bigomby self-assigned this Mar 14, 2020
@Bitcoinera
Copy link
Contributor

I think we better merge #69 first before we look into this one

@mariopino
Copy link
Contributor

I think we better merge #69 first before we look into this one

Agree!

@Bigomby
Copy link
Member Author

Bigomby commented Mar 14, 2020

Yes, actually this PR depends on #69

@derfredy derfredy removed the request for review from aitorjs March 14, 2020 20:06
@mariopino
Copy link
Contributor

Yes, actually this PR depends on #69

Perfect @Bigomby please, #69 is already merged, please merge develop so we can merge this asap.

@Bitcoinera
Copy link
Contributor

Bitcoinera commented Mar 15, 2020 •
edited
Loading

I merged but now I am getting a lot of errors... Although they are also present in develop anyways.

From staking (since we need to refactor there currentElected and get rid of the .at(<hash>) like in #63) and also again the infamous duplicated keys for blocks. This one is back.

EDIT: Let's merge this

@derfredy derfredy requested a review from mariopino March 16, 2020 09:55
Bitcoinera
Bitcoinera reviewed Mar 19, 2020
View reviewed changes
.prettierrc Outdated
@@ -0,0 +1,4 @@
{
"singleQuote": true,
"trailingComma": "all"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like trailing commas 😜

@Bigomby Bigomby marked this pull request as draft April 15, 2020 08:42
@Bigomby Bigomby changed the title [WIP] Implement linters Implement linters Apr 15, 2020
mariopino
mariopino approved these changes Apr 26, 2020
View reviewed changes
Copy link
Contributor

@mariopino mariopino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! I think we need this merged before starting with milestone 3.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Bitcoinera Bitcoinera Bitcoinera left review comments

@mariopino mariopino mariopino approved these changes

@derfredy derfredy Awaiting requested review from derfredy

Assignees

@Bigomby Bigomby

Labels
enhancement New feature or request
Projects
None yet
Milestone
Milestone 1
Development

Successfully merging this pull request may close these issues.
3 participants
@Bigomby @Bitcoinera @mariopino