Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing pre-commit fixes #21

Merged
merged 5 commits into from
May 21, 2024
Merged

Failing pre-commit fixes #21

merged 5 commits into from
May 21, 2024

Conversation

Sachinbisht27
Copy link
Member

@Sachinbisht27 Sachinbisht27 commented May 21, 2024 •
edited
Loading

#[ISSUE_ID]

Please complete the following steps and check these boxes before filing your PR:

Types of changes

  • Bug fix (a change which fixes an issue)
  • New feature (a change which adds functionality)

Short description of what this resolves:

  • Pre-commit is failing to run on all environments.
  • Auto formatting of code by pre-commit.
  • Removed extra unused code.
  • Updated dependencies.

Checklist:

  • I have performed a self-review of my own code.
  • The code follows the style guidelines of this project.
  • The code changes are passing the CI checks
  • I have documented my code wherever required.
  • The changes requires a change to the documentation.
  • I have updated the documentation based on the my changes.
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@Sachinbisht27 Sachinbisht27 added the bug Something isn't working label May 21, 2024
@Sachinbisht27 Sachinbisht27 requested a review from Satendra-SR May 21, 2024 11:17
@Sachinbisht27 Sachinbisht27 self-assigned this May 21, 2024
Satendra-SR
Satendra-SR approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@Satendra-SR Satendra-SR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Satendra-SR Satendra-SR merged commit b1d0375 into main May 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Satendra-SR Satendra-SR Satendra-SR approved these changes

Assignees

@Sachinbisht27 Sachinbisht27

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sachinbisht27 @Satendra-SR