Send email to visit guide and external cord. person on authorization …

[tarunnjoshi]

…of campSend email to visit guide and external cord. person on authorization …

Summary by CodeRabbit

• New Features

  • Introduced a new method for sending visit details and email notifications based on authorization status.
  • Enhanced visit feedback handling with a corrected method name.

• Bug Fixes

  • Corrected typographical error in method name for sending visit feedback.

• Improvements

  • Updated visit status checks to include new authorization criteria and improved error logging for better tracking.

[coderabbitai]

Walkthrough

The pull request modifies the UrbanPlannedVisitService class in the CiviCRM extension, focusing on improving visit-related event handling. Key changes include renaming a method with a typo, introducing a new method for sending visit details, and adding a method to check authorization visit statuses. The modifications aim to enhance email notification mechanisms and status validation for urban planned visits.

Changes

File	Change Summary
wp-content/civi-extensions/goonjcustom/Civi/UrbanPlannedVisitService.php	- Renamed sendVistFeedbackForm to sendVisitFeedbackForm - Added sendVisitDetails method for post-database write event handling - Added checkAuthVisitStatusAndIds method for authorization status validation - Updated error logging for visit status checks

Sequence Diagram

sequenceDiagram
    participant System
    participant UrbanPlannedVisitService
    participant EmailNotification

    System->>UrbanPlannedVisitService: Trigger visit event
    UrbanPlannedVisitService->>UrbanPlannedVisitService: Check visit status
    UrbanPlannedVisitService->>UrbanPlannedVisitService: Validate authorization
    UrbanPlannedVisitService->>EmailNotification: Send visit details/feedback

Loading

Possibly related PRs

• Send feedback Form To external coordinating poc #656: Modifies the same UrbanPlannedVisitService class, updating checkVisitStatusAndIds method for improved visit status handling

Suggested labels

status: ready for review

Suggested reviewers

• belwalshubham

Poem

🏙️ Urban visits dance and sway,
Code refactored, errors kept at bay
Feedback flows with newfound grace
Status checks now find their place
A digital symphony of urban might! 🌆

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

wp-content/civi-extensions/goonjcustom/Civi/UrbanPlannedVisitService.php (2)

31-126: Consider extracting common email logic to a shared helper.
The code for fetching contact info, verifying email existence, and sending the message largely mirrors other methods like “sendVisitFeedbackForm.” This could be factored out to maintain a single responsibility per method and reduce duplication.

Watch out for inconsistent capitalization in conditional statements.
At line 119, “If ($emailSendResultToExternalPoc)” uses an uppercase “If.” For consistent coding standards, align with lowercase “if.”

---

298-322: Check for partial duplication in status checks.
Lines 298-322 incorporate both visit status and authorization checks. Some logic overlaps with the newly introduced “checkAuthVisitStatusAndIds” method. Consider merging or clearly separating responsibilities for better maintainability.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 208bbfe and 1f40103.

📒 Files selected for processing (1)

• wp-content/civi-extensions/goonjcustom/Civi/UrbanPlannedVisitService.php (3 hunks)

🔇 Additional comments (3)

wp-content/civi-extensions/goonjcustom/Civi/UrbanPlannedVisitService.php (3)

25-26: Good addition to hooks, but ensure cohesive naming.
Registering both "sendVisitFeedbackForm" and "sendVisitDetails" is fine, but please ensure consistent naming and responsibilities across all hooks to avoid confusion.

---

198-198: Method renaming fix is correct.
Renaming “sendVistFeedbackForm” to “sendVisitFeedbackForm” improves clarity and resolves the earlier typo.

---

324-357: Method extraction is sensible, but watch single responsibility.
This new method centralizes the authorization status check. However, ensure that it only handles data retrieval and doesn’t bleed into sending emails or updating records to avoid future complexity.